* [patch] brcmfmac: move dereference under check for NULL
@ 2013-06-06 10:55 Dan Carpenter
2013-06-06 11:46 ` Arend van Spriel
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-06-06 10:55 UTC (permalink / raw)
To: Brett Rudley
Cc: Arend van Spriel, Franky (Zhenhui) Lin, Hante Meuleman,
John W. Linville, Pieter-Paul Giesberts, Piotr Haber,
linux-wireless, brcm80211-dev-list, kernel-janitors
skb_pull() dereferences the skb parameter.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
index ea37bd4..c35296f 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
@@ -861,9 +861,9 @@ static bool brcmf_fws_tim_update(struct brcmf_fws_info *fws,
BRCMF_FWS_TYPE_PENDING_TRAFFIC_BMP_LEN + 2 +
4 + fws->drvr->hdrlen;
skb = brcmu_pkt_buf_get_skb(len);
- skb_pull(skb, len);
if (skb == NULL)
return false;
+ skb_pull(skb, len);
skcb = brcmf_skbcb(skb);
skcb->mac = entry;
skcb->state = BRCMF_FWS_SKBSTATE_TIM;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] brcmfmac: move dereference under check for NULL
2013-06-06 10:55 [patch] brcmfmac: move dereference under check for NULL Dan Carpenter
@ 2013-06-06 11:46 ` Arend van Spriel
0 siblings, 0 replies; 2+ messages in thread
From: Arend van Spriel @ 2013-06-06 11:46 UTC (permalink / raw)
To: Dan Carpenter
Cc: Brett Rudley, Franky (Zhenhui) Lin, Hante Meuleman,
John W. Linville, Pieter-Paul Giesberts, Piotr Haber,
linux-wireless, brcm80211-dev-list, kernel-janitors
On 06/06/2013 12:55 PM, Dan Carpenter wrote:
> skb_pull() dereferences the skb parameter.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Hi Dan,
Just missed that. This code fragment was resubmitted just minutes ago. I
will rework the patch to incorporate this change.
Regards,
Arend
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> index ea37bd4..c35296f 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> @@ -861,9 +861,9 @@ static bool brcmf_fws_tim_update(struct brcmf_fws_info *fws,
> BRCMF_FWS_TYPE_PENDING_TRAFFIC_BMP_LEN + 2 +
> 4 + fws->drvr->hdrlen;
> skb = brcmu_pkt_buf_get_skb(len);
> - skb_pull(skb, len);
> if (skb == NULL)
> return false;
> + skb_pull(skb, len);
> skcb = brcmf_skbcb(skb);
> skcb->mac = entry;
> skcb->state = BRCMF_FWS_SKBSTATE_TIM;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-06 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-06 10:55 [patch] brcmfmac: move dereference under check for NULL Dan Carpenter
2013-06-06 11:46 ` Arend van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).