From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:54916 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751326Ab3FFVgG (ORCPT ); Thu, 6 Jun 2013 17:36:06 -0400 Message-ID: <51B100C2.8070905@wwwdotorg.org> (sfid-20130606_233611_071533_750FD4DD) Date: Thu, 06 Jun 2013 15:36:02 -0600 From: Stephen Warren MIME-Version: 1.0 To: Arend van Spriel CC: "John W. Linville" , Hante Meuleman , "'linux-wireless@vger.kernel.org'" , "linux-next@vger.kernel.org" Subject: Re: Regression in 9390ace brcmfmac: free net device when registration fails References: <51AD1F22.2080004@wwwdotorg.org> <51ADE47D.50700@broadcom.com> <51B0FAC0.4080709@broadcom.com> In-Reply-To: <51B0FAC0.4080709@broadcom.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/06/2013 03:10 PM, Arend van Spriel wrote: > On 06/04/13 14:58, Arend van Spriel wrote: >> On 06/04/2013 12:56 AM, Stephen Warren wrote: >>> (John, note that this commit is part of the pull request you sent to >>> Dave today) >>> >>> Arend, >>> >>> Commit 9390ace "brcmfmac: free net device when registration fails" >>> causes a regression. >>> >>> I had the BCM4330 firmware present in my root fs, whereas my HW is a >>> BCM4329. With this patch applied, I get a kernel panic on boot. With it >>> reverted, I see that no issues of that nature. This is true in >>> next-20130531 (and also 5/30 and 6/1 but not earlier). A bisect of >>> Linus's tree followed by a merge of John's wireless pull request from >>> today pointed at this same commit. >> >> Thanks, Stephen >> >> I will look into this. > > Hi Stephen, > > Can you try the attached patch? If it does not solve the issue, could > you provide a log. Yes, that works great, thanks. Tested-by: Stephen Warren >>> Related: Since the two hardware require different firmware, I wonder why >>> the driver doesn't use a firmware filename that encodes the HW device ID >>> instead of using the same name for all HW. This means that when I move >>> my SD card between development systems, I have to copy different >>> firmware over the top. That's a little painful... >> >> I agree that for development switching cards it is kinda awkward and I >> have been fooled by it as well. We may want to change or if your itch is >> annoying enough feel free to send a patch for it ;-) > > We have a patch for this that we can submit to wireless-next. Oh, great! If you could Cc me, that'd be helpful, since I'm not on that list. Thanks.