From: Felix Fietkau <nbd@openwrt.org>
To: Jean-Pierre Tosoni <jp.tosoni@acksys.fr>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC v2] mac80211: Use libnl-configurable values for retry counts
Date: Mon, 01 Jul 2013 11:04:27 +0200 [thread overview]
Message-ID: <51D1461B.3040905@openwrt.org> (raw)
In-Reply-To: <000401ce7635$de99d1d0$9bcd7570$@acksys.fr>
On 2013-07-01 10:34 AM, Jean-Pierre Tosoni wrote:
> Thanks Felix.
>
> I am using the ath9k, but I have seen this in the b43 driver:
>
> rates[0].count = dev->wl->hw->conf.short_frame_max_tx_count;
>
> Do you think that short/long_frame_max_tx_count should rather be applied at
> the driver level (not mac80211) ?
> The ath9k driver currently enforces a minimum retry count of 30 (constant),
> it could be replaced with short/long_frame_max_tx_count ?
No, I think driver level is even more wrong than generic mac80211 rate
table code. The driver doesn't know more than mac80211 about how to
properly distribute a limited set of retries across different rates.
The only place that can properly control this is the rate control module.
The ath9k retry count of 30 that you're mentioning is software retry -
you should leave that one alone for now and focus on hardware retries.
- Felix
next prev parent reply other threads:[~2013-07-01 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 16:40 [RFC v2] mac80211: Use libnl-configurable values for retry counts Jean-Pierre Tosoni
2013-06-29 20:08 ` Felix Fietkau
2013-07-01 8:34 ` Jean-Pierre Tosoni
2013-07-01 9:04 ` Felix Fietkau [this message]
2013-07-02 13:28 ` Jean-Pierre Tosoni
2013-07-02 13:50 ` Felix Fietkau
2013-07-02 17:40 ` Jean-Pierre Tosoni
2013-07-02 18:05 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D1461B.3040905@openwrt.org \
--to=nbd@openwrt.org \
--cc=jp.tosoni@acksys.fr \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).