Re: [PATCH 2/3] [RFC] cfg80211: Add Kconfig option for cellular BS hints

["Arend van Spriel" <arend@broadcom.com>]

On 07/02/2013 02:28 PM, Ilan Peer wrote:
> Move the regulatory cellular base station hints support under
> a specific configuration option and make the option depend
> on CFG80211_CERTIFICATION_ONUS.

This one seems not really related to the other patches. On itself it is 
not clear to me what itch is being scratched here. Is the aim to get rid 
of the CERTIFICATION_ONUS dependency further along the road?

Regards,
Arend

> Signed-off-by: Ilan Peer <ilan.peer@intel.com>
> ---
>   net/wireless/Kconfig |    7 +++++++
>   net/wireless/reg.c   |    2 +-
>   2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
> index 16d08b3..de76078 100644
> --- a/net/wireless/Kconfig
> +++ b/net/wireless/Kconfig
> @@ -95,6 +95,13 @@ config CFG80211_CERTIFICATION_ONUS
>   	  you are a wireless researcher and are working in a controlled
>   	  and approved environment by your local regulatory agency.
>
> +config CFG80211_REG_CELLULAR_HINTS
> +	bool "cfg80211 regulatory support for cellular base station hints"
> +	depends on CFG80211 && CFG80211_CERTIFICATION_ONUS
> +	---help---
> +	  This option adds support for drivers that can receive regulatory
> +	  hints from cellular base stations
> +
>   config CFG80211_DEFAULT_PS
>   	bool "enable powersave by default"
>   	depends on CFG80211
> diff --git a/net/wireless/reg.c b/net/wireless/reg.c
> index 5a24c98..2459a69 100644
> --- a/net/wireless/reg.c
> +++ b/net/wireless/reg.c
> @@ -928,7 +928,7 @@ bool reg_last_request_cell_base(void)
>   	return reg_request_cell_base(get_last_request());
>   }
>
> -#ifdef CONFIG_CFG80211_CERTIFICATION_ONUS
> +#ifdef CONFIG_CFG80211_REG_CELLULAR_HINTS
>   /* Core specific check */
>   static enum reg_request_treatment
>   reg_ignore_cell_hint(struct regulatory_request *pending_request)
>