From: John Greene <jogreene@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linville@tuxdriver.com, arend@broadcom.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] brcmsmac: Further reduce log spam from tx phy messages
Date: Mon, 15 Jul 2013 08:15:44 -0400 [thread overview]
Message-ID: <51E3E7F0.7050308@redhat.com> (raw)
In-Reply-To: <1373652022.2614.13.camel@joe-AO722>
On 07/12/2013 02:00 PM, Joe Perches wrote:
> On Fri, 2013-07-12 at 10:55 -0400, John Greene wrote:
>> Relegate 2 phy messages to debug status as they create excessive
>> log spam, noted in multiple bugzillas for brcmsmac v3.8 and up.
>
> Hi John,
>
> Just trivia:
>
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> []
>> @@ -928,7 +928,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
> []
>> - brcms_err(wlc->hw->d11core,
>> + brcms_dbg_ht(wlc->hw->d11core,
>> "%s: ampdu tx phy error (0x%x)\n",
>> __func__, txs->phyerr);
>
> Please keep the indentation of the arguments of
> the same statement aligned to the open parenthesis.
>
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> []
>> @@ -882,7 +882,7 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
> []
>> - brcms_err(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
>> + brcms_dbg_tx(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
>> txs->phyerr, txh->MainRates);
>
> Here too.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Thanks Joe. My oversight. I wish the checkpatch flagged this stuff.
I'll fix this and post v2.
--
John Greene
next prev parent reply other threads:[~2013-07-15 12:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 14:55 [PATCH] brcmsmac: Further reduce log spam from tx phy messages John Greene
2013-07-12 18:00 ` Joe Perches
2013-07-15 12:15 ` John Greene [this message]
2013-07-15 12:23 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E3E7F0.7050308@redhat.com \
--to=jogreene@redhat.com \
--cc=arend@broadcom.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).