linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ortwin Glück" <odi@odi.ch>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Arend van Spriel <arend@broadcom.com>,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [BUG] 3.10 regression: hang on suspend
Date: Mon, 22 Jul 2013 21:05:39 +0200	[thread overview]
Message-ID: <51ED8283.3060901@odi.ch> (raw)
In-Reply-To: <20130722112236.GA7364@redhat.com>

On 07/22/2013 01:22 PM, Stanislaw Gruszka wrote:
> We remove interface that we do not add in the driver. I think I found
> reason of that - I removed below code in bad commit:
>
>          list_for_each_entry(sdata, &local->interfaces, list) {
> [snip]
> -               switch (sdata->vif.type) {
> -               case NL80211_IFTYPE_AP_VLAN:
> -               case NL80211_IFTYPE_MONITOR:
> -                       /* skip these */
> -                       continue;

Oh yes, that makes a lot of sense! I have an extra monitoring interface 
configured. If I remove that before suspend, the crash does not occur.

And your patch does fix the problem. Very nice!

Thank you,

Ortwin


      reply	other threads:[~2013-07-22 19:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15 19:40 [BUG] 3.10 regression: hang on suspend Ortwin Glück
2013-07-16  6:56 ` Stanislaw Gruszka
2013-07-16  7:34   ` Ortwin Glück
2013-07-16  9:49     ` Arend van Spriel
2013-07-16 18:23       ` Ortwin Glück
2013-07-17 12:29         ` Stanislaw Gruszka
     [not found]           ` <51E6E1AB.5010300@odi.ch>
2013-07-18 10:55             ` Stanislaw Gruszka
     [not found]               ` <51E83AB7.6020002@odi.ch>
2013-07-19 12:08                 ` Stanislaw Gruszka
2013-07-19 12:11                   ` Stanislaw Gruszka
2013-07-19 12:15                   ` Ortwin Glück
2013-07-19 18:46                   ` Ortwin Glück
2013-07-22 11:22                     ` Stanislaw Gruszka
2013-07-22 19:05                       ` Ortwin Glück [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51ED8283.3060901@odi.ch \
    --to=odi@odi.ch \
    --cc=arend@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).