linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Mark Schulte <schultetwin@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] rtlwifi: sparse warnings: cast to restricted type
Date: Wed, 31 Jul 2013 12:21:45 -0500	[thread overview]
Message-ID: <51F947A9.3050802@lwfinger.net> (raw)
In-Reply-To: <1375254507-26154-2-git-send-email-schultetwin@gmail.com>

On 07/31/2013 02:08 AM, Mark Schulte wrote:
> Adding type casts to suppress sparse warnings:
>   * warning: cast to restricted __le32/__le16
>
> Signed-off-by: Mark Schulte <schultetwin@gmail.com>
> ---
>   drivers/net/wireless/rtlwifi/ps.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)

I think this patch is OK, but until I get a chance to test it on a big-endian 
machine (PowerBook G4 Titanium), please do not apply it.

When I tried the patch, I discovered some kind of regression that causes a 
kernel oops with an RTL8192CU device installed. This patch is not the problem, 
but I will need to bisect the oops before I can test. The machine takes a long 
time to build each kernel, thus it will probably be a while.

Larry


  reply	other threads:[~2013-07-31 17:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31  7:08 [PATCH 1/2] rtlwifi: rtl8192cu: fix function declaration header Mark Schulte
2013-07-31  7:08 ` [PATCH 2/2] rtlwifi: sparse warnings: cast to restricted type Mark Schulte
2013-07-31 17:21   ` Larry Finger [this message]
2013-08-09 17:41     ` John W. Linville
2013-08-09 22:08       ` Larry Finger
2013-07-31 15:02 ` [PATCH 1/2] rtlwifi: rtl8192cu: fix function declaration header Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F947A9.3050802@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=schultetwin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).