Linux wireless drivers development
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
	Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: RE: RCU WARNING Splat from rtw8822bu
Date: Mon, 8 May 2023 08:59:11 +0000	[thread overview]
Message-ID: <51ff479741ea4ff88cd317f193acf7db@realtek.com> (raw)
In-Reply-To: <f1e31e8e-f84e-3791-50fb-663a83c5c6e9@lwfinger.net>



> -----Original Message-----
> From: Larry Finger <larry.finger@gmail.com> On Behalf Of Larry Finger
> Sent: Monday, May 8, 2023 8:56 AM
> To: Ping-Ke Shih <pkshih@realtek.com>; Sascha Hauer <s.hauer@pengutronix.de>
> Cc: linux-wireless <linux-wireless@vger.kernel.org>
> Subject: Re: RCU WARNING Splat from rtw8822bu
> 
> On 5/7/23 19:49, Ping-Ke Shih wrote:
> > The ieee80211_ops::sta_rc_update must be atomic, because ieee80211_chan_bw_change()
> > holds rcu_read lock while calling drv_sta_rc_update(), so I think a simple way is
> > to create a work to do original things. I will make a fix later.
> 
> Thanks.
> 
> I forgot to say that the WARNING did not cause the wifi connection to be
> dropped, thus the issue is one of log spamming, not stability.
> 

I have sent a fix [1]. Please try if it works in your side.

[1] https://lore.kernel.org/linux-wireless/20230508085429.46653-1-pkshih@realtek.com/T/#u

Thank you
Ping-Ke


  reply	other threads:[~2023-05-08  8:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-07 19:24 RCU WARNING Splat from rtw8822bu Larry Finger
2023-05-08  0:49 ` Ping-Ke Shih
2023-05-08  0:55   ` Larry Finger
2023-05-08  8:59     ` Ping-Ke Shih [this message]
2023-05-08  9:09 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51ff479741ea4ff88cd317f193acf7db@realtek.com \
    --to=pkshih@realtek.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox