From: "Arend van Spriel" <arend@broadcom.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
"Johannes Berg" <johannes.berg@intel.com>
Subject: Re: [PATCH] brcmfmac: use CFG80211_TESTMODE_CMD
Date: Wed, 7 Aug 2013 12:45:00 +0200 [thread overview]
Message-ID: <5202252C.6030802@broadcom.com> (raw)
In-Reply-To: <1375780399-1120-1-git-send-email-johannes@sipsolutions.net>
On 08/06/2013 11:13 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> This is essentially the same, but written shorter.
I would have expected the macro to be called NL80211.. but no real
preference. So you can add
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> index b7d8850..f393828 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> @@ -4163,9 +4163,7 @@ static struct cfg80211_ops wl_cfg80211_ops = {
> .stop_p2p_device = brcmf_p2p_stop_device,
> .crit_proto_start = brcmf_cfg80211_crit_proto_start,
> .crit_proto_stop = brcmf_cfg80211_crit_proto_stop,
> -#ifdef CONFIG_NL80211_TESTMODE
> - .testmode_cmd = brcmf_cfg80211_testmode
> -#endif
> + CFG80211_TESTMODE_CMD(brcmf_cfg80211_testmode)
> };
>
> static s32 brcmf_nl80211_iftype_to_mode(enum nl80211_iftype type)
>
prev parent reply other threads:[~2013-08-07 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 9:13 [PATCH] brcmfmac: use CFG80211_TESTMODE_CMD Johannes Berg
2013-08-07 10:45 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5202252C.6030802@broadcom.com \
--to=arend@broadcom.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).