* [PATCH] brcmfmac: use CFG80211_TESTMODE_CMD
@ 2013-08-06 9:13 Johannes Berg
2013-08-07 10:45 ` Arend van Spriel
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2013-08-06 9:13 UTC (permalink / raw)
To: linux-wireless; +Cc: Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
This is essentially the same, but written shorter.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
index b7d8850..f393828 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
@@ -4163,9 +4163,7 @@ static struct cfg80211_ops wl_cfg80211_ops = {
.stop_p2p_device = brcmf_p2p_stop_device,
.crit_proto_start = brcmf_cfg80211_crit_proto_start,
.crit_proto_stop = brcmf_cfg80211_crit_proto_stop,
-#ifdef CONFIG_NL80211_TESTMODE
- .testmode_cmd = brcmf_cfg80211_testmode
-#endif
+ CFG80211_TESTMODE_CMD(brcmf_cfg80211_testmode)
};
static s32 brcmf_nl80211_iftype_to_mode(enum nl80211_iftype type)
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] brcmfmac: use CFG80211_TESTMODE_CMD
2013-08-06 9:13 [PATCH] brcmfmac: use CFG80211_TESTMODE_CMD Johannes Berg
@ 2013-08-07 10:45 ` Arend van Spriel
0 siblings, 0 replies; 2+ messages in thread
From: Arend van Spriel @ 2013-08-07 10:45 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Johannes Berg
On 08/06/2013 11:13 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> This is essentially the same, but written shorter.
I would have expected the macro to be called NL80211.. but no real
preference. So you can add
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> index b7d8850..f393828 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> @@ -4163,9 +4163,7 @@ static struct cfg80211_ops wl_cfg80211_ops = {
> .stop_p2p_device = brcmf_p2p_stop_device,
> .crit_proto_start = brcmf_cfg80211_crit_proto_start,
> .crit_proto_stop = brcmf_cfg80211_crit_proto_stop,
> -#ifdef CONFIG_NL80211_TESTMODE
> - .testmode_cmd = brcmf_cfg80211_testmode
> -#endif
> + CFG80211_TESTMODE_CMD(brcmf_cfg80211_testmode)
> };
>
> static s32 brcmf_nl80211_iftype_to_mode(enum nl80211_iftype type)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-07 10:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-06 9:13 [PATCH] brcmfmac: use CFG80211_TESTMODE_CMD Johannes Berg
2013-08-07 10:45 ` Arend van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).