From: Marc Kleine-Budde <mkl@blackshift.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-wireless@vger.kernel.org, linux@rempel-privat.de,
ath9k-devel@lists.ath9k.org,
Helmut Schaa <helmut.schaa@googlemail.com>
Subject: Re: [PATCH v2] ath9k_htc: Restore skb headroom when returning skb to mac80211
Date: Tue, 20 Aug 2013 11:01:36 +0200 [thread overview]
Message-ID: <52133070.2050301@blackshift.org> (raw)
In-Reply-To: <1376681980-27831-1-git-send-email-mkl@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]
On 08/16/2013 09:39 PM, Marc Kleine-Budde wrote:
> From: Helmut Schaa <helmut.schaa@googlemail.com>
>
> ath9k_htc adds padding between the 802.11 header and the payload during
> TX by moving the header. When handing the frame back to mac80211 for TX
> status handling the header is not moved back into its original position.
> This can result in a too small skb headroom when entering ath9k_htc
> again (due to a soft retransmission for example) causing an
> skb_under_panic oops.
>
> Fix this by moving the 802.11 header back into its original position
> before returning the frame to mac80211 as other drivers like rt2x00
> or ath5k do.
>
> Reported-by: Marc Kleine-Budde <mkl@blackshift.org>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> Tested-by: Marc Kleine-Budde <mkl@blackshift.org>
> Signed-off-by: Marc Kleine-Budde <mkl@blackshift.org>
> ---
> Hello Helmut,
>
> I've change the patch a bit, I've used ieee80211_get_hdrlen_from_skb() instead
> of open coding it.
>
> Tested in ARMv5 with USB device
> "ID 0cf3:7015 Atheros Communications, Inc. TP-Link TL-WN821N v3 802.11n [Atheros AR7010+AR9287]"
> for four weeks. Without that patch the kernel oopes after about one week.
>
> I think this is a candidate for stable, can you add stable to Cc?
ping
Marc
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]
next prev parent reply other threads:[~2013-08-20 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 19:39 [PATCH v2] ath9k_htc: Restore skb headroom when returning skb to mac80211 Marc Kleine-Budde
2013-08-20 9:01 ` Marc Kleine-Budde [this message]
2013-08-20 12:57 ` Helmut Schaa
2013-08-20 12:59 ` Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52133070.2050301@blackshift.org \
--to=mkl@blackshift.org \
--cc=ath9k-devel@lists.ath9k.org \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox