From: "Arend van Spriel" <arend@broadcom.com>
To: "Felix Fietkau" <nbd@openwrt.org>
Cc: "Linux Wireless List" <linux-wireless@vger.kernel.org>
Subject: Re: [REGRESSION] 3.10.{6,7} crashes on network activity
Date: Tue, 20 Aug 2013 21:04:53 +0200 [thread overview]
Message-ID: <5213BDD5.60308@broadcom.com> (raw)
In-Reply-To: <5213A926.8060306@openwrt.org>
On 08/20/2013 07:36 PM, Felix Fietkau wrote:
> On 2013-08-20 10:15 AM, Arend van Spriel wrote:
>> Hi Felix,
>>
>> I have been diving into root causing why brcmsmac can not handle cck
>> fallback rates, because it should. Maybe it is better to flag no cck
>> support and only change brcmsmac.
> I prefer having a flag to enable it over one to disable it, because it
> fits better with the existing flags. Also, future drivers may not always
> be properly prepared to handle CCK in A-MPDU sessions either.
Ok. It just looked a bit strange that a problem in brcmsmac results in
changing other drivers.
> By the way, I took a short look at brcmsmac and found more issues that
> you should look into if you want to fix this.
>
> First of all, you should probably make sure that the hardware does not
> try to send an A-MPDU using a CCK rate (prepare it as a single frame in
> brcms_c_ampdu_add_frame). It also does not seem to have any checks to
> ensure that rate control probing frames are not aggregated.
Thanks, Felix. I also noticed that our proprietary driver has code in
place for these scenarios.
Gr. AvS
next prev parent reply other threads:[~2013-08-20 19:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAG-2HqUXQeq=30EpGWmn6tkC=CP1W+=UZCVPTYhhE0WyU_C4nw@mail.gmail.com>
2013-08-20 0:03 ` [REGRESSION] 3.10.{6,7} crashes on network activity Greg Kroah-Hartman
2013-08-20 0:26 ` Tom Gundersen
2013-08-20 0:28 ` Greg Kroah-Hartman
2013-08-20 4:56 ` Felix Fietkau
2013-08-20 8:15 ` Arend van Spriel
2013-08-20 8:36 ` Tom Gundersen
2013-08-20 9:58 ` Arend van Spriel
2013-08-20 10:10 ` Georgios Magklaras
2013-08-20 17:36 ` Felix Fietkau
2013-08-20 19:04 ` Arend van Spriel [this message]
2013-08-21 0:11 ` Josh Boyer
2013-08-21 8:52 ` Arend van Spriel
2013-08-21 12:38 ` Josh Boyer
2013-08-21 14:27 ` Arend van Spriel
2013-08-21 14:45 ` Josh Boyer
2013-08-20 8:34 ` Tom Gundersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5213BDD5.60308@broadcom.com \
--to=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).