From: Gabor Juhos <juhosg@openwrt.org>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/7] ath10k: remove void pointer from struct ath10k_pci_compl
Date: Fri, 30 Aug 2013 22:46:41 +0200 [thread overview]
Message-ID: <522104B1.2070004@openwrt.org> (raw)
In-Reply-To: <20130830123021.31164.8374.stgit@localhost6.localdomain6>
2013.08.30. 14:30 keltezéssel, Kalle Valo írta:
> Void pointers are bad, mmkay.
>
> No functional changes.
>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/pci.c | 12 ++++++------
> drivers/net/wireless/ath/ath10k/pci.h | 2 +-
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
<snip>
> @@ -1026,7 +1026,7 @@ static void ath10k_pci_process_ce(struct ath10k *ar)
> break;
> }
>
> - skb = (struct sk_buff *)compl->transfer_context;
> + skb = (struct sk_buff *)compl->skb;
The cast can be removed from here as well.
> nbytes = compl->nbytes;
>
> ath10k_dbg(ATH10K_DBG_PCI,
> diff --git a/drivers/net/wireless/ath/ath10k/pci.h b/drivers/net/wireless/ath/ath10k/pci.h
> index c65fe1b..2e1f422 100644
> --- a/drivers/net/wireless/ath/ath10k/pci.h
> +++ b/drivers/net/wireless/ath/ath10k/pci.h
> @@ -54,7 +54,7 @@ struct ath10k_pci_compl {
> enum ath10k_pci_compl_state state;
> struct ath10k_ce_pipe *ce_state;
> struct ath10k_pci_pipe *pipe_info;
> - void *transfer_context;
> + struct sk_buff *skb;
> unsigned int nbytes;
> unsigned int transfer_id;
> unsigned int flags;
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
>
next prev parent reply other threads:[~2013-08-30 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 12:29 [PATCH 0/7] ath10k: pci cleanup Kalle Valo
2013-08-30 12:30 ` [PATCH 1/7] ath10k: pci: make host_ce_config_wlan[] more readable Kalle Valo
2013-08-30 12:30 ` [PATCH 2/7] ath10k: make target_ce_config_wlan " Kalle Valo
2013-08-30 12:30 ` [PATCH 3/7] ath10k: remove void pointer from struct ath10k_pci_compl Kalle Valo
2013-08-30 20:46 ` Gabor Juhos [this message]
2013-09-01 6:16 ` Kalle Valo
2013-08-30 12:30 ` [PATCH 4/7] ath10k: convert ath10k_pci_reg_read/write32() to take struct ath10k Kalle Valo
2013-08-30 12:30 ` [PATCH 5/7] ath10k: clean up ath10k_ce_completed_send_next_nolock() Kalle Valo
2013-08-30 12:30 ` [PATCH 6/7] ath10k: convert ath10k_pci_wake() to return Kalle Valo
2013-08-30 12:30 ` [PATCH 7/7] ath10k: simplify ath10k_ce_init() wake up handling Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522104B1.2070004@openwrt.org \
--to=juhosg@openwrt.org \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).