From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mms1.broadcom.com ([216.31.210.17]:2835 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753237Ab3HaSV1 (ORCPT ); Sat, 31 Aug 2013 14:21:27 -0400 Message-ID: <5222341B.4070205@broadcom.com> (sfid-20130831_202148_270788_88583D8E) Date: Sat, 31 Aug 2013 20:21:15 +0200 From: "Arend van Spriel" MIME-Version: 1.0 To: "Geert Uytterhoeven" cc: "Randy Dunlap" , "Stephen Rothwell" , Linux-Next , "linux-kernel@vger.kernel.org" , linux-wireless , brcm80211-dev-list@broadcom.com, linux-kbuild Subject: Re: linux-next: Tree for Aug 30 (brcmfmac) References: <20130829200013.d9dde1eb64686a32c661b5d3@canb.auug.org.au> <52210AB9.2090104@infradead.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 08/31/13 19:37, Geert Uytterhoeven wrote: > On Fri, Aug 30, 2013 at 11:12 PM, Randy Dunlap wrote: >> This bool kconfig symbol: >> >> config BRCMFMAC_SDIO >> bool "SDIO bus interface support for FullMAC driver" >> depends on MMC >> >> allows BRCMFMAC_SDIO to be y even when MMC=m. >> >> Is there a reasonable solution to this? Actually, BRCMFMAC should be built in same form as the MMC and/or USB, but only when BRCMFMAC_SDIO or BRCMFMAC_USB are selected. So valid combinations are: MMC=m, USB=m, BRCMFMAC_SDIO=y, BRCMFMAC_USB=y => BRCMFMAC=m MMC=m, USB=y, BRCMFMAC_SDIO=y, BRCMFMAC_USB=y => BRCMFMAC=m MMC=y, USB=m, BRCMFMAC_SDIO=y, BRCMFMAC_USB=y => BRCMFMAC=m MMC=m, USB=y, BRCMFMAC_SDIO=y, BRCMFMAC_USB=n => BRCMFMAC=m MMC=m, USB=y, BRCMFMAC_SDIO=n, BRCMFMAC_USB=y => BRCMFMAC=m|y MMC=y, USB=m, BRCMFMAC_SDIO=y, BRCMFMAC_USB=n => BRCMFMAC=m|y MMC=y, USB=m, BRCMFMAC_SDIO=n, BRCMFMAC_USB=y => BRCMFMAC=m MMC=y, USB=y, BRCMFMAC_SDIO=y, BRCMFMAC_USB=y => BRCMFMAC=m|y MMC=y, USB=y, BRCMFMAC_SDIO=y, BRCMFMAC_USB=n => BRCMFMAC=m|y MMC=y, USB=y, BRCMFMAC_SDIO=n, BRCMFMAC_USB=y => BRCMFMAC=m|y Not sure how to express the above. Gr. AvS > In order of preference: > 1. Make it tristate > 2. depends on MMC=y > > However, the first solution cannot be used as there are several > "#ifdef CONFIG_BRCMFMAC_SDIO" in the code itself. > > Note that there's a similar issue with BRCMFMAC_USB and USB. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >