From: Johannes Berg <johannes@sipsolutions.net>
To: Thorsten Leemhuis <regressions@leemhuis.info>,
Ping-Ke Shih <pkshih@realtek.com>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"art1310@proton.me" <art1310@proton.me>,
Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: [PATCH rtw-next v2] wifi: rtl8xxxu: Detect the maximum supported channel width
Date: Tue, 12 May 2026 11:36:26 +0200 [thread overview]
Message-ID: <522d09d5fad2fdebc89419a7e75b89ff14de162a.camel@sipsolutions.net> (raw)
In-Reply-To: <02c073d8-d2c9-4faa-be51-9ba38247b24e@leemhuis.info>
On Tue, 2026-05-12 at 10:54 +0200, Thorsten Leemhuis wrote:
> > > You
> > > can cherry-pick or directly apply the fix to a pending branch (or even
> > > ask Linus to merge it directly from the list, but that is likely not
> > > worth it here) and git will normally later notice this and fully
> > > automatically handle everything when the fix comes in again during the
> > > next merge window.
> >
> > I know git can handle that, but is it an acceptable practice for single one
> > commit to appear twice?
>
> Depends on whom you ask. I'd say: It's kinda normal. It's best avoided
> if there is no need, but if there is a need (like here) it's fine. And
> some subsystems it even happens regularly iirc.
FWIW, it's generally frowned upon and actually uncommon enough that
linux-next actively warns about it [1] (or at least used to?), so I
wouldn't really say your description here is all that accurate.
[1] https://lore.kernel.org/lkml/?q=%22duplicate+patch+in+the%22
What does happen fairly frequently is the same immutable commit getting
merged through different branches, but that's a single commit, not the
same change being committed twice.
johannes
next prev parent reply other threads:[~2026-05-12 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 12:02 [PATCH rtw-next v2] wifi: rtl8xxxu: Detect the maximum supported channel width Bitterblue Smith
2026-05-06 7:57 ` Ping-Ke Shih
2026-05-11 11:05 ` Thorsten Leemhuis
2026-05-12 0:44 ` Ping-Ke Shih
2026-05-12 7:17 ` Thorsten Leemhuis
2026-05-12 8:32 ` Ping-Ke Shih
2026-05-12 8:54 ` Thorsten Leemhuis
2026-05-12 9:36 ` Johannes Berg [this message]
2026-05-12 11:30 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522d09d5fad2fdebc89419a7e75b89ff14de162a.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Jes.Sorensen@gmail.com \
--cc=art1310@proton.me \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox