From: Gabor Juhos <juhosg@openwrt.org>
To: Paul Menzel <paulepanter@users.sourceforge.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [rt2x00-users] [PATCH 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the extended EEPROM map
Date: Thu, 03 Oct 2013 14:05:57 +0200 [thread overview]
Message-ID: <524D5DA5.3090702@openwrt.org> (raw)
In-Reply-To: <1380789509.8125.6.camel@mattotaupa>
Dear Paul,
<...>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
>> index c706ddc..c979bb7 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -280,10 +280,8 @@ static const unsigned int rt2800_eeprom_map_ext[EEPROM_WORD_COUNT] = {
>> [EEPROM_RSSI_BG] = 0x0028,
>> [EEPROM_TXPOWER_DELTA] = 0x0028, /* Overlaps with RSSI_BG */
>> [EEPROM_RSSI_BG2] = 0x0029,
>> - [EEPROM_TXMIXER_GAIN_BG] = 0x0029, /* Overlaps with RSSI_BG2 */
>> [EEPROM_RSSI_A] = 0x002a,
>> [EEPROM_RSSI_A2] = 0x002b,
>> - [EEPROM_TXMIXER_GAIN_A] = 0x002b, /* Overlaps with RSSI_A2 */
>> [EEPROM_TXPOWER_BG1] = 0x0030,
>> [EEPROM_TXPOWER_BG2] = 0x0037,
>> [EEPROM_EXT_TXPOWER_BG3] = 0x003e,
>
> Do you know if this fixes any problems and should be backported to
> stable?
This is a cleanup patch, it does not fix any problem. The removed entries are
not used by the code at all.
> If any testing can be done on
>
> idVendor 0x148f Ralink Technology, Corp.
> idProduct 0x2870 RT2870 Wireless Adapter
>
> please tell me.
The extended EEPROM map is used only for the RT3593 chipset, it does not affect
RT2870 in any way.
>
> With the fixes above,
>
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Thank you for the review! I will send an updated version.
-Gabor
prev parent reply other threads:[~2013-10-03 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 19:41 [PATCH 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the extended EEPROM map Gabor Juhos
2013-10-02 19:41 ` [PATCH 2/2] rt2x00: rt2800lib: remove TXPOWER_DELTA entry from " Gabor Juhos
2013-10-03 8:40 ` [rt2x00-users] " Paul Menzel
2013-10-03 8:38 ` [rt2x00-users] [PATCH 1/2] rt2x00: rt2800lib: remove TXMIXER_GAIN entries from the " Paul Menzel
2013-10-03 12:05 ` Gabor Juhos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524D5DA5.3090702@openwrt.org \
--to=juhosg@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=paulepanter@users.sourceforge.net \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).