From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Kevin Lo <kevlo@kevlo.org>, John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [rt2x00-users] [PATCH] rt2x00: rt2800lib: no need to write RF register 3 twice for RT5592
Date: Thu, 14 Nov 2013 17:42:31 +0100 [thread overview]
Message-ID: <5284FD77.2080702@gmail.com> (raw)
In-Reply-To: <20131114055344.GA74271@ns.kevlo.org>
On 11/14/13 06:53, Kevin Lo wrote:
> In rt2800_init_rfcsr_5592(), there's no need to write RF register 3 twice.
>
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
> ---
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 776aff3..18506f8 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -6602,7 +6602,6 @@ static void rt2800_init_rfcsr_5592(struct rt2x00_dev *rt2x00dev)
>
> rt2800_rfcsr_write(rt2x00dev, 1, 0x3F);
> rt2800_rfcsr_write(rt2x00dev, 3, 0x08);
> - rt2800_rfcsr_write(rt2x00dev, 3, 0x08);
> rt2800_rfcsr_write(rt2x00dev, 5, 0x10);
> rt2800_rfcsr_write(rt2x00dev, 6, 0xE4);
> rt2800_rfcsr_write(rt2x00dev, 7, 0x00);
>
> _______________________________________________
> users mailing list
> users@rt2x00.serialmonkey.com
> http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
>
--
---
Gertjan
prev parent reply other threads:[~2013-11-14 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 5:53 [PATCH] rt2x00: rt2800lib: no need to write RF register 3 twice for RT5592 Kevin Lo
2013-11-14 16:42 ` Gertjan van Wingerde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284FD77.2080702@gmail.com \
--to=gwingerde@gmail.com \
--cc=kevlo@kevlo.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).