Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luka Gejak <luka.gejak@linux.dev>
To: Mehmet Fide <mehmet.fide@gmail.com>, Ping-Ke Shih <pkshih@realtek.com>
Cc: Zong-Zhe Yang <kevin_yang@realtek.com>,
	Tzu-En Huang <tehuang@realtek.com>,
	Yan-Hsuan Chuang <yhchuang@realtek.com>,
	Kalle Valo <kvalo@kernel.org>,
	Stanislaw Gruszka <sgruszka@redhat.com>,
	Brian Norris <briannorris@chromium.org>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next v2 1/3] wifi: rtw88: free the reserved pages of an interface on firmware recovery
Date: Mon, 16 Nov 2026 17:02:39 +0100	[thread overview]
Message-ID: <5285DA11-651F-4286-A0FD-52A6051B3A88@linux.dev> (raw)
In-Reply-To: <20261116072014.1142494-2-mehmet.fide@gmail.com>

Hi Mehmet,

Thanks for the update. Three comments below.

On November 16, 2026 8:20:12 AM GMT+01:00, Mehmet Fide
<mehmet.fide@gmail.com> wrote:

> @@ -1800,8 +1800,10 @@ void rtw_fw_update_beacon_work(struct work_struct *work)
> +     if (!test_bit(RTW_FLAG_RESTARTING, rtwdev->flags)) {
> +             rtw_fw_download_rsvd_page(rtwdev);
> +             rtw_send_rsvd_page_h2c(rtwdev);
> +     }

Could a skipped TIM update be retried at reconfig_complete()? After
reconfig's last beacon download, sta_info_cleanup() can still expire a
buffered frame and queue this work. If it runs before the flag clears,
the beacon keeps the old TIM bit.

[ ... ]

> +     if (!test_bit(RTW_FLAG_RESTARTING, rtwdev->flags)) {

Also, if the last interface closes before restart work takes the wiphy
lock, open_count is zero and reconfig_complete() is skipped. The flag
survives normal reopening, so the worker still skips TIM updates.
Could that exit be covered too?

[ ... ]

> @@ -627,6 +627,7 @@ static void rtw_reset_vif_iter(void *data, u8 *mac, struct ieee80211_vif *vif)
> +     rtw_remove_rsvd_page(rtwdev, rtwvif);

As far as I can see, rtw_core_stop() drops the driver mutex without
holding wiphy. A concurrent beacon change can then reach:

        ieee80211_change_beacon()
          rtw_ops_bss_info_changed()
            rtw_fw_download_rsvd_page()

The lists are already empty, and mac80211 restart has not begun yet.
This seems to leave a path to the empty reserved page warning.
Could the direct download path be covered too?

Best regards,
Luka Gejak

  reply	other threads:[~2026-11-16 16:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:20 [PATCH rtw-next v2 0/3] wifi: rtw88: three fixes around the firmware recovery Mehmet Fide
2026-11-16  7:20 ` [PATCH rtw-next v2 1/3] wifi: rtw88: free the reserved pages of an interface on " Mehmet Fide
2026-11-16 16:02   ` Luka Gejak [this message]
2026-11-16  7:20 ` [PATCH rtw-next v2 2/3] wifi: rtw88: report the frames purged from the TX report queue Mehmet Fide
2026-11-16  7:20 ` [PATCH rtw-next v2 3/3] wifi: rtw88: reset the stations outside of RCU on firmware recovery Mehmet Fide
2026-11-16 15:55   ` Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5285DA11-651F-4286-A0FD-52A6051B3A88@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=briannorris@chromium.org \
    --cc=kevin_yang@realtek.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mehmet.fide@gmail.com \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=pkshih@realtek.com \
    --cc=sgruszka@redhat.com \
    --cc=tehuang@realtek.com \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox