From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mms1.broadcom.com ([216.31.210.17]:4265 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324Ab3KQVbU convert rfc822-to-8bit (ORCPT ); Sun, 17 Nov 2013 16:31:20 -0500 Message-ID: <5289359B.8090506@broadcom.com> (sfid-20131117_223145_925514_B5C171FA) Date: Sun, 17 Nov 2013 22:31:07 +0100 From: "Arend van Spriel" MIME-Version: 1.0 To: "Borislav Petkov" cc: lkml , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-wireless@vger.kernel.org Subject: Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS References: <20131117133702.GA30840@pd.tnic> In-Reply-To: <20131117133702.GA30840@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/17/13 14:37, Borislav Petkov wrote: > From: Borislav Petkov > > When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get > > drivers/built-in.o: In function `brcms_led_unregister': > (.text+0x351aca): undefined reference to `led_classdev_unregister' > drivers/built-in.o: In function `brcms_led_register': > (.text+0x351c65): undefined reference to `led_classdev_register' > > during the final linking stage because brcmsmac/led.c needs LEDS_CLASS > for reg/dereg. Fix that. Wouldn't it be better to fix it in brcmsmac. Gr AvS > Cc: "Rafał Miłecki" > Cc: linux-wireless@vger.kernel.org > Signed-off-by: Borislav Petkov > --- > > I'm attaching the .config in question. > > drivers/bcma/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig > index 7c081b38ef3e..74dba9ca1413 100644 > --- a/drivers/bcma/Kconfig > +++ b/drivers/bcma/Kconfig > @@ -74,7 +74,7 @@ config BCMA_DRIVER_GMAC_CMN > > config BCMA_DRIVER_GPIO > bool "BCMA GPIO driver" > - depends on BCMA&& GPIOLIB > + depends on BCMA&& GPIOLIB&& LEDS_CLASS > help > Driver to provide access to the GPIO pins of the bcma bus. >