From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <sujith@msujith.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 1/2] ath9k_hw: fix TSF save/restore around chip reset
Date: Tue, 19 Nov 2013 00:33:55 +0100 [thread overview]
Message-ID: <528AA3E3.1080601@openwrt.org> (raw)
In-Reply-To: <21130.39398.379492.921373@gargle.gargle.HOWL>
On 2013-11-18 23:51, Sujith Manoharan wrote:
> Felix Fietkau wrote:
>> A cold reset can be triggered because of DMA stop issues, and this leads
>> to TSF being cleared on all chipsets. To properly deal with this, always
>> save the TSF.
>
> I think this needs to be done only when we are in operational state.
> There is no need to do this before the station interface is associated
> or the AP interface is up.
Technically yes, but in practice it doesn't really matter, so I'd prefer
to keep the code simple.
For scanning we don't really hit this codepath much anyway: The first
reset skips it because of the transition out of full-sleep, subsequent
resets tend to use fast channel changes most of the time, which also
doesn't do the TSF save/restore.
- Felix
prev parent reply other threads:[~2013-11-18 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 19:14 [PATCH 1/2] ath9k_hw: fix TSF save/restore around chip reset Felix Fietkau
2013-11-18 19:14 ` [PATCH 2/2] ath9k_hw: allow fast channel change when only CHANNEL_HT changes Felix Fietkau
2013-11-18 22:51 ` [PATCH 1/2] ath9k_hw: fix TSF save/restore around chip reset Sujith Manoharan
2013-11-18 23:33 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528AA3E3.1080601@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox