From: Felix Fietkau <nbd@openwrt.org>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: use capped prob when computing throughputs
Date: Wed, 20 Nov 2013 15:04:34 +0100 [thread overview]
Message-ID: <528CC172.1040402@openwrt.org> (raw)
In-Reply-To: <20131120135628.GA9335@magnum.frso.rivierawaves.com>
On 2013-11-20 14:56, Karl Beldan wrote:
> On Wed, Nov 20, 2013 at 08:32:32AM +0100, Felix Fietkau wrote:
>> On 2013-11-20 01:51, Karl Beldan wrote:
>> > From: Karl Beldan <karl.beldan@rivierawaves.com>
>> >
>> > Commit 3e8b1eb "mac80211/minstrel_ht: improve rate selection stability"
>> > introduced a local capped prob in minstrel_ht_calc_tp but omitted to use
>> > it to compute the rate throughput.
>> >
>> > Signed-off-by: Karl Beldan <karl.beldan@rivierawaves.com>
>> > CC: Felix Fietkau <nbd@openwrt.org>
>> Nice catch!
>> Acked-by: Felix Fietkau <nbd@openwrt.org>
>>
> Interestingly enough, consecutive coding rates (5/6, 3/4, 2/3) max ratio
> is 9/10, did you do it on purpose ? (e.g. (9/10) * (5/6) == 3/4,
> (9/10) * (3/4) == 2/3 + 11/120).
The change has nothing to do with coding rates, it's only about
retransmissions caused by collisions under load.
- Felix
next prev parent reply other threads:[~2013-11-20 14:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 0:51 [PATCH] mac80211: use capped prob when computing throughputs Karl Beldan
2013-11-20 7:32 ` Felix Fietkau
2013-11-20 13:56 ` Karl Beldan
2013-11-20 14:04 ` Felix Fietkau [this message]
2013-11-20 14:50 ` Karl Beldan
2013-11-20 15:49 ` Felix Fietkau
2013-11-20 16:19 ` Karl Beldan
2013-11-20 17:32 ` Felix Fietkau
2013-11-20 17:53 ` Karl Beldan
2013-11-20 18:24 ` Felix Fietkau
2013-11-20 16:57 ` Felix Fietkau
2013-11-20 17:03 ` Karl Beldan
2013-11-20 17:04 ` Karl Beldan
2013-11-20 17:37 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528CC172.1040402@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=karl.beldan@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox