From: Johannes Berg <johannes@sipsolutions.net>
To: Veerendranath Jakkam <vjakkam@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] cfg80211: Enhance the AKM advertizement to support per interface.
Date: Sun, 26 Jan 2020 18:32:45 +0100 [thread overview]
Message-ID: <5290eda7dee50997e7fa5bb5976256b024f7e94e.camel@sipsolutions.net> (raw)
In-Reply-To: <20200126112113.19542-1-vjakkam@codeaurora.org>
On Sun, 2020-01-26 at 16:51 +0530, Veerendranath Jakkam wrote:
>
> +
> + nested = nla_nest_start(msg, NL80211_ATTR_IFTYPE_AKM_SUITES);
> + if (!nested)
> + return -ENOBUFS;
> +
> + for (i = 0; i < rdev->wiphy.num_iftype_akm_suites; i++) {
> + nested_akms = nla_nest_start(msg, i + 1);
> + if (!nested_akms)
> + return -ENOBUFS;
> +
> + iftype_akms = &rdev->wiphy.iftype_akm_suites[i];
> +
> + if (nl80211_put_iftypes(msg, NL80211_ATTR_SUPPORTED_IFTYPES,
> + iftype_akms->iftypes_mask))
> + return -ENOBUFS;
> +
> + if (nla_put(msg, NL80211_ATTR_AKM_SUITES,
Using the top-level attributes inside the nesting makes things
unnecessarily difficult to understand and take far more memory to parse,
IMHO it'd be better to define a new set of inner attributes
NL80211_IFTYPE_AKM_ATTR_IFTYPES, ..._SUITES or so.
johannes
next prev parent reply other threads:[~2020-01-26 17:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 18:52 [PATCH] cfg80211: Enhance the AKM advertizement to support per interface Veerendranath Jakkam
2020-01-02 13:41 ` Johannes Berg
2020-01-17 11:34 ` vjakkam
2020-01-02 13:45 ` Johannes Berg
2020-01-17 11:33 ` vjakkam
2020-01-17 11:35 ` [PATCH v2] " Veerendranath Jakkam
2020-01-20 8:57 ` Arend Van Spriel
2020-01-26 11:10 ` vjakkam
2020-01-26 11:21 ` [PATCH v3] " Veerendranath Jakkam
2020-01-26 17:32 ` Johannes Berg [this message]
2020-01-26 20:23 ` vjakkam
2020-01-26 20:30 ` [PATCH v4] " Veerendranath Jakkam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5290eda7dee50997e7fa5bb5976256b024f7e94e.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=vjakkam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).