* [PATCH] brcmsmac: remove dependency on CRC8 and CRC_CCITT
@ 2013-11-24 21:03 Hauke Mehrtens
2013-11-25 9:25 ` Arend van Spriel
0 siblings, 1 reply; 2+ messages in thread
From: Hauke Mehrtens @ 2013-11-24 21:03 UTC (permalink / raw)
To: linville; +Cc: arend, brcm80211-dev-list, linux-wireless, Hauke Mehrtens
There is no code in brcmsmac that uses a function from CRC8 or
CRC_CCITT any more. Building brcmsmac with these two disabled works
without any problems. This was probably only used by the bus code which
was replaced by bcma some time ago.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
drivers/net/wireless/brcm80211/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig
index b00a7e9..ce0add3 100644
--- a/drivers/net/wireless/brcm80211/Kconfig
+++ b/drivers/net/wireless/brcm80211/Kconfig
@@ -7,8 +7,6 @@ config BRCMSMAC
depends on BCMA
select BRCMUTIL
select FW_LOADER
- select CRC_CCITT
- select CRC8
select CORDIC
---help---
This module adds support for PCIe wireless adapters based on Broadcom
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] brcmsmac: remove dependency on CRC8 and CRC_CCITT
2013-11-24 21:03 [PATCH] brcmsmac: remove dependency on CRC8 and CRC_CCITT Hauke Mehrtens
@ 2013-11-25 9:25 ` Arend van Spriel
0 siblings, 0 replies; 2+ messages in thread
From: Arend van Spriel @ 2013-11-25 9:25 UTC (permalink / raw)
To: Hauke Mehrtens, linville; +Cc: brcm80211-dev-list, linux-wireless
On 11/24/2013 10:03 PM, Hauke Mehrtens wrote:
> There is no code in brcmsmac that uses a function from CRC8 or
> CRC_CCITT any more. Building brcmsmac with these two disabled works
> without any problems. This was probably only used by the bus code which
> was replaced by bcma some time ago.
True. These could be removed when using bcma. Thanks for cleaning that up.
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/wireless/brcm80211/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig
> index b00a7e9..ce0add3 100644
> --- a/drivers/net/wireless/brcm80211/Kconfig
> +++ b/drivers/net/wireless/brcm80211/Kconfig
> @@ -7,8 +7,6 @@ config BRCMSMAC
> depends on BCMA
> select BRCMUTIL
> select FW_LOADER
> - select CRC_CCITT
> - select CRC8
> select CORDIC
> ---help---
> This module adds support for PCIe wireless adapters based on Broadcom
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-25 9:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-24 21:03 [PATCH] brcmsmac: remove dependency on CRC8 and CRC_CCITT Hauke Mehrtens
2013-11-25 9:25 ` Arend van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).