Re: [PATCH] mac80211: add helper functions for tracking P2P NoA state

[Antonio Quartulli <antonio@meshcoding.com>]

On 09/12/13 16:59, Felix Fietkau wrote:
[...]
> +/**
> + * struct ieee80211_noa_data - holds temporary data for tracking P2P NoA state
> + *
> + * @next_tsf: TSF timestamp of the next absent state change
> + * @has_next_tsf: next absent state change event pending
> + *
> + * @absent: descriptor bitmask, set if GO is currently absent
> + */

why not providing the kerneldoc for all the fields? Even the more
obvious for you may not be so obvious for the next poor reader that has
to touch this code :-)

> +struct ieee80211_noa_data {
> +	u32 next_tsf;
> +	bool has_next_tsf;
> +
> +	u8 absent;
> +
> +	u8 count[IEEE80211_P2P_NOA_DESC_MAX];
> +	struct {
> +		u32 start;
> +		u32 duration;
> +		u32 interval;
> +	} desc[IEEE80211_P2P_NOA_DESC_MAX];
> +};


Cheers,

-- 
Antonio Quartulli