From: Felix Fietkau <nbd@openwrt.org>
To: Antonio Quartulli <antonio@meshcoding.com>,
linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net
Subject: Re: [PATCH] mac80211: add helper functions for tracking P2P NoA state
Date: Mon, 09 Dec 2013 19:19:15 +0100 [thread overview]
Message-ID: <52A609A3.9030708@openwrt.org> (raw)
In-Reply-To: <52A60603.3010606@meshcoding.com>
On 2013-12-09 19:03, Antonio Quartulli wrote:
> On 09/12/13 16:59, Felix Fietkau wrote:
> [...]
>> +/**
>> + * struct ieee80211_noa_data - holds temporary data for tracking P2P NoA state
>> + *
>> + * @next_tsf: TSF timestamp of the next absent state change
>> + * @has_next_tsf: next absent state change event pending
>> + *
>> + * @absent: descriptor bitmask, set if GO is currently absent
>> + */
>
> why not providing the kerneldoc for all the fields? Even the more
> obvious for you may not be so obvious for the next poor reader that has
> to touch this code :-)
The driver should not care about those, they're private for the mac80211
utility function.
- Felix
prev parent reply other threads:[~2013-12-09 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 15:59 [PATCH] mac80211: add helper functions for tracking P2P NoA state Felix Fietkau
2013-12-09 18:03 ` Antonio Quartulli
2013-12-09 18:19 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A609A3.9030708@openwrt.org \
--to=nbd@openwrt.org \
--cc=antonio@meshcoding.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox