Re: [PATCH rtw-next v3 5/5] wifi: rtw88: 8812a, 8821a: respect peer A-MPDU size limits

[Luka Gejak <luka.gejak@linux.dev>]

On November 13, 2026 9:16:33 AM GMT+01:00, Jie Feng <hjf3108@gmail.com>
wrote:
>On Fri, 13 Nov 2026 at 16:10, Luka Gejak <luka.gejak@linux.dev> wrote:
>>
>> Hi Jie Feng,
>>
>> Thanks for the patch. One small question below.
>>
>> On November 12, 2026 6:32:44 PM GMT+01:00, Ho Jie Feng
><hjf3108@gmail.com>
>> wrote:
>>
>> > diff --git a/drivers/net/wireless/realtek/rtw88/rtw8812a.c
>b/drivers/net/wireless/realtek/rtw88/rtw8812a.c
>> > index c8008cf43d..c8f5cdf31c 100644
>> > --- a/drivers/net/wireless/realtek/rtw88/rtw8812a.c
>> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8812a.c
>>
>> [ ... ]
>>
>> > +static void rtw8812a_set_ampdu_factor(struct rtw_dev *rtwdev, u8
>factor)
>> > +{
>> > +     factor = min_t(u8, factor, IEEE80211_VHT_MAX_AMPDU_128K);
>> > +
>> > +     rtw_write32(rtwdev, REG_AMPDU_MAX_LENGTH,
>> > +                 ((8192 << factor) - 1) | BIT(31));
>> > +}
>>
>> What does BIT(31) do here? I see the vendor driver sets it too, so I
>> think it is right, but a define in reg.h or a short comment would make
>> it easier to follow. The same goes for rtw8821a_set_ampdu_factor().
>I reviewed it again and saw it, so I added it to be at parity with the
>vendor code.
>

Can you add a define in reg.h or a short comment, as that would make it
more readable?

Best regards,
Luka Gejak