From: Felix Fietkau <nbd@openwrt.org>
To: Ding Tianhong <dingtianhong@huawei.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 19/21] wireless: slight optimization of addr compare
Date: Mon, 23 Dec 2013 14:47:13 +0100 [thread overview]
Message-ID: <52B83EE1.4040705@openwrt.org> (raw)
In-Reply-To: <52B7C600.8030907@huawei.com>
On 2013-12-23 06:11, Ding Tianhong wrote:
> Use the recently added and possibly more efficient
> ether_addr_equal_unaligned to instead of memcmp.
It looks to me like all of these (including the ones in the other
similar patches) are in places, where the address data is aligned to at
least 16 bit. Because of this, using ether_addr_equal instead of
ether_addr_equal_unaligned would be much better for platforms without
CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS.
- Felix
next prev parent reply other threads:[~2013-12-23 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 5:11 [PATCH 19/21] wireless: slight optimization of addr compare Ding Tianhong
2013-12-23 13:47 ` Felix Fietkau [this message]
2013-12-23 14:14 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B83EE1.4040705@openwrt.org \
--to=nbd@openwrt.org \
--cc=dingtianhong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).