From: Larry Finger <Larry.Finger@lwfinger.net>
To: andrea.merello@gmail.com,
Bernhard Schiffner <bernhard@schiffner-limbach.de>
Cc: John Linville <linville@tuxdriver.com>,
Greg Kroah-Hartman <greg@kroah.com>,
linux-wireless@vger.kernel.org
Subject: Re: RTL8187SE staging Linux driver
Date: Tue, 14 Jan 2014 15:50:52 -0600 [thread overview]
Message-ID: <52D5B13C.3040006@lwfinger.net> (raw)
In-Reply-To: <CAN8YU5PGkx9s9deWpFTO_ZtDr-+wDD5cX2JRv1zd1m1Q0BpkCw@mail.gmail.com>
On 01/14/2014 11:40 AM, Andrea Merello wrote:
> Hello Bernhard,
>
> Are you still curious to test something ? :)
> I attach a patch that should apply to wireless-testing..
>
> I still have several items pending on my TODO list, including things
> to tidy/fix, and things that are currently missing, however I'm
> getting encouraging results on my setup..
>
> If this works for you, and if other people in CC here agree, I may
> starting split this mega-patch in something more suitable for kernel
> maintainers to merge (currently it even changes few misleading names
> in the common register struct, affecting also rtl8187 driver)..
>
> Let me know if it works :)
Andrea,
Building your version gets the following warning:
CC [M] drivers/net/wireless/rtl818x/rtl8187/rfkill.o
drivers/net/wireless/rtl818x/rtl8187/dev.c: In function ‘rtl8187_set_anaparam’:
drivers/net/wireless/rtl818x/rtl8187/dev.c:596:3: warning: passing argument 2 of
‘rtl818x_iowrite8’ from incompatible pointer type [enabled by default]
In file included from drivers/net/wireless/rtl818x/rtl8187/dev.c:32:0:
drivers/net/wireless/rtl818x/rtl8187/rtl8187.h:237:20: note: expected ‘u8 *’ but
argument is of type ‘__le16 *’
The easy fix is to change that to an ...iowrite16() call. So far, my testing to
see if writing that extra byte messes up the RTL8187B has not shown any
problems; however, I have not yet tested on a big-endian machine.
Have you given any thought to renaming the driver? It seems to me that rtl8180
was probably not right when it drove both RTL8180 and RTL8185, and it is even
less appropriate today.
The driver connects to the following APs:
802.11n running WPA2
802.11g running WPA1
802.11g running WEP
Looks good.
Larry
next prev parent reply other threads:[~2014-01-14 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 15:59 RTL8187SE staging Linux driver Andrea Merello
2013-09-10 16:56 ` John W. Linville
2013-09-10 17:35 ` Larry Finger
2013-09-11 6:11 ` Andrea Merello
2014-01-14 17:40 ` Andrea Merello
2014-01-14 21:50 ` Larry Finger [this message]
2014-01-15 16:11 ` Larry Finger
2014-01-15 17:22 ` Andrea Merello
2014-01-15 17:42 ` Larry Finger
2014-01-15 18:41 ` Andrea Merello
2014-01-15 18:43 ` Andrea Merello
2014-01-15 20:29 ` Larry Finger
2014-01-20 21:48 ` Andrea Merello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D5B13C.3040006@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=andrea.merello@gmail.com \
--cc=bernhard@schiffner-limbach.de \
--cc=greg@kroah.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).