linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@meshcoding.com>
To: Sujith Manoharan <sujith@msujith.org>,
	Simon Wunderlich <sw@simonwunderlich.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>,
	"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
	linux-wireless@vger.kernel.org,
	Teemu Paasikivi <ext-teemu.3.paasikivi@nokia.com>
Subject: Re: IBSS can't beacon after rejoin / regression in TSF syncing code?
Date: Tue, 28 Jan 2014 08:29:14 +0100	[thread overview]
Message-ID: <52E75C4A.3030506@meshcoding.com> (raw)
In-Reply-To: <21223.2785.44186.69761@gargle.gargle.HOWL>

[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]

On 28/01/14 02:41, Sujith Manoharan wrote:
> Simon Wunderlich wrote:
>> Yeah, this patch works for my case. I'm not completely sure why we only unlink 
>> for this special case (no stations & bssid = zero), I don't see why it would 
>> hurt to always throw away that BSS and rescan on the next join?
>>
>> I'm CCing Teemu, who introduced this roughly 3.5 years ago ("mac80211: remove 
>> BSS from cfg80211 list when leaving IBSS", 
>> 5ea096c0c85e80335889539899af9a4717976e0b) , maybe he can explain it more.  I 
>> couldn't understand that from the commit message and the corresponding mail 
>> thread.
> 
> I think we can drop the BSS when we leave an IBSS network. The only advantage
> of not doing so is a slightly faster join command that is given after
> leaving - if there are more than 2 nodes in the cell, that is. But it would
> be prudent to scan and check if the network exists before trying to join it,
> so I'll send the patch for review.

Right now no scan takes place if you specify bssid and freq (+
fixed_freq attr). Then no matter if the BSS is already the scan list:
the join command will be fast.


Cheers,

-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2014-01-28  7:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 17:26 IBSS can't beacon after rejoin / regression in TSF syncing code? Simon Wunderlich
2014-01-27  4:25 ` Sujith Manoharan
2014-01-27 13:27   ` Simon Wunderlich
2014-01-27 13:34     ` Simon Wunderlich
2014-01-28  1:41     ` Sujith Manoharan
2014-01-28  7:29       ` Antonio Quartulli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E75C4A.3030506@meshcoding.com \
    --to=antonio@meshcoding.com \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=ext-teemu.3.paasikivi@nokia.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mathias.kretschmer@fokus.fraunhofer.de \
    --cc=sujith@msujith.org \
    --cc=sw@simonwunderlich.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).