From: Antonio Quartulli <antonio@open-mesh.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"brcm80211-dev-list@broadcom.com"
<brcm80211-dev-list@broadcom.com>,
Arend van Spriel <arend@broadcom.com>,
Bing Zhao <bzhao@marvell.com>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
"libertas-dev@lists.infradead.org"
<libertas-dev@lists.infradead.org>
Subject: Re: [PATCH RESEND mac80211] cfg80211: fix channel configuration in IBSS join
Date: Tue, 28 Jan 2014 14:31:32 +0100 [thread overview]
Message-ID: <52E7B134.2040404@open-mesh.com> (raw)
In-Reply-To: <87wqhkgszo.fsf@kamboji.qca.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
On 28/01/14 14:01, Kalle Valo wrote:
>> - Patch is getting resent because I did not CC'd the linux-wireless mailing list in
>> my previous attempt. :)
>
> Oh, I missed that. Anyway, in previous version I commented about
> documenting NULL usage. What do you think about that?
Well documentation is always good :) If it is need I will add it.
However, I'd rather ask you what ath6kl is trying to do in that case,
since it's the only driver invoking cfg80211_ibss_joined() with a zero
BSSID (and now a NULL channel) on IBSS leave.
From the cfg80211 prospective, that call is seen like a notification of
being connected to a new BSS having zero mac and NULL channel. I don't
see how this can be useful at all, also because after leaving the IBSS I
imagine that no other operation will take place on that vif unless it
reconnects again.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-28 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 12:52 [PATCH RESEND mac80211] cfg80211: fix channel configuration in IBSS join Antonio Quartulli
2014-01-28 13:01 ` Kalle Valo
2014-01-28 13:31 ` Antonio Quartulli [this message]
2014-01-28 13:36 ` Johannes Berg
2014-01-28 13:36 ` Antonio Quartulli
2014-01-29 12:10 ` Johannes Berg
2014-01-29 12:12 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E7B134.2040404@open-mesh.com \
--to=antonio@open-mesh.com \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=bzhao@marvell.com \
--cc=johannes@sipsolutions.net \
--cc=jussi.kivilinna@iki.fi \
--cc=kvalo@qca.qualcomm.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).