[PATCH] ath6kl: removed useless ibss_joined notification on ibss_leave

[PATCH] ath6kl: removed useless ibss_joined notification on ibss_leave

[Antonio Quartulli]

When leaving an IBSS there is no need to send cfg80211 a
fake notification about "having joined a cell with zero
BSSID".
This operation has the only effect to create a BSS object
that is not going to be used.

Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
 drivers/net/wireless/ath/ath6kl/cfg80211.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index eba32f5..8ce1ce5 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -790,7 +790,6 @@ void ath6kl_cfg80211_connect_event(struct ath6kl_vif *vif, u16 channel,
 	if (nw_type & ADHOC_NETWORK) {
 		ath6kl_dbg(ATH6KL_DBG_WLAN_CFG, "ad-hoc %s selected\n",
 			   nw_type & ADHOC_CREATOR ? "creator" : "joiner");
-		cfg80211_ibss_joined(vif->ndev, bssid, GFP_KERNEL);
 		cfg80211_put_bss(ar->wiphy, bss);
 		return;
 	}
-- 
1.8.5.3

Re: [PATCH] ath6kl: removed useless ibss_joined notification on ibss_leave

[Antonio Quartulli]

[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]

On 28/01/14 17:00, Antonio Quartulli wrote:
> When leaving an IBSS there is no need to send cfg80211 a
> fake notification about "having joined a cell with zero
> BSSID".
> This operation has the only effect to create a BSS object
> that is not going to be used.
> 
> Cc: Kalle Valo <kvalo@qca.qualcomm.com>
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
> ---
>  drivers/net/wireless/ath/ath6kl/cfg80211.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> index eba32f5..8ce1ce5 100644
> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> @@ -790,7 +790,6 @@ void ath6kl_cfg80211_connect_event(struct ath6kl_vif *vif, u16 channel,
>  	if (nw_type & ADHOC_NETWORK) {
>  		ath6kl_dbg(ATH6KL_DBG_WLAN_CFG, "ad-hoc %s selected\n",
>  			   nw_type & ADHOC_CREATOR ? "creator" : "joiner");


Of course I messed it up :)
This is not the right place for this change!!!
Will send v2.


Cheers,

-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]