From: Jahnavi Meher <jahnavi.meher@redpinesignals.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3.13.1 3/9] rsi: Packet queueing/dequeueing to device
Date: Fri, 31 Jan 2014 16:25:51 +0530 [thread overview]
Message-ID: <52EB8137.1000405@redpinesignals.com> (raw)
In-Reply-To: <1391103351.4323.23.camel@jlt4.sipsolutions.net>
WMM is being implemented in the hardware, the packets are
being scheduled similarly to help out the scheduling in the
hardware. Will consider the cases when multiple devices are
using the same driver and incorporate the changes.
Regards,
Jahnavi
On 01/30/2014 11:05 PM, Johannes Berg wrote:
On Thu, 2014-01-30 at 21:24 +0530, Jahnavi wrote:
>> +#ifdef USE_SDIO_INTF
>> +static unsigned int pkt_count;
>> +#endif
>> +static unsigned int selected_qnum, pkt_cnt;
> static variables are a really bad idea, especially ones like this. Have
> you ever thought about more than one USB device being plugged in to the
> same machine? :)
>
> Also, I'm not sure trying to implement QoS in software is a great idea,
> or does it only look like that's what you're doing?
>
> johannes
>
>
>
next prev parent reply other threads:[~2014-01-31 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 15:54 [PATCH 3.13.1 3/9] rsi: Packet queueing/dequeueing to device Jahnavi
2014-01-30 17:35 ` Johannes Berg
2014-01-31 10:55 ` Jahnavi Meher [this message]
2014-01-30 17:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EB8137.1000405@redpinesignals.com \
--to=jahnavi.meher@redpinesignals.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).