Re: [rt2x00-users] [PATCH] rt2800: disable PS by default on USB

[Gertjan van Wingerde <gwingerde@gmail.com>]

On 01/29/14 17:42, Stanislaw Gruszka wrote:
> We have disabled it currently on other buses. PS can cause some issues,
> not necessarily with our driver but on AP, that are not easy to debug.
> Since behaviour differs on rt2800usb and rt2800pci, user usually blame
> for malfunction rt2800usb driver, whereas issue is on AP side.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>

Looks a bit drastic to me, but if it helps users:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2800lib.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 776aff3..510dde0 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -7453,10 +7453,9 @@ static int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
>  	u32 reg;
>  
>  	/*
> -	 * Disable powersaving as default on PCI devices.
> +	 * Disable powersaving as default.
>  	 */
> -	if (rt2x00_is_pci(rt2x00dev) || rt2x00_is_soc(rt2x00dev))
> -		rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> +	rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
>  
>  	/*
>  	 * Initialize all hw fields.
> 


-- 
---
Gertjan