From: Larry Finger <Larry.Finger@lwfinger.net>
To: andrea.merello@gmail.com, Dan Carpenter <dan.carpenter@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Stefan Lippers-Hollmann <s.L-H@gmx.de>,
Dave Jones <davej@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Wireless List <linux-wireless@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Driver Project <devel@linuxdriverproject.org>
Subject: Re: rtl8821ae.
Date: Tue, 04 Feb 2014 11:57:36 -0600 [thread overview]
Message-ID: <52F12A10.3020600@lwfinger.net> (raw)
In-Reply-To: <CAN8YU5PfJ2ijHzghJ-FJPYJeFwTfoGN-qpJ5R5ctYp3R1p13hA@mail.gmail.com>
Andrea,
After applying the latest patch, I get the following warning and errors when
building the USB driver rtl8187:
CC drivers/video/fbmon.o
drivers/net/wireless/rtl818x/rtl8187/dev.c: In function ‘rtl8187_set_anaparam’:
drivers/net/wireless/rtl818x/rtl8187/dev.c:595:3: warning: passing argument 2 of
‘rtl818x_iowrite8’ from incompatible pointer type [enabled by default]
rtl818x_iowrite8(priv, &priv->map->ANAPARAM3, anaparam3);
^
In file included from drivers/net/wireless/rtl818x/rtl8187/dev.c:31:0:
drivers/net/wireless/rtl818x/rtl8187/rtl8187.h:237:20: note: expected ‘u8 *’ but
argument is of type ‘__le16 *’
static inline void rtl818x_iowrite8(struct rtl8187_priv *priv, u8 *addr, u8 val)
^
drivers/net/wireless/rtl818x/rtl8187/dev.c: In function ‘rtl8187b_init_hw’:
drivers/net/wireless/rtl818x/rtl8187/dev.c:788:9: error:
‘RTL818X_CW_CONF_PERPACKET_RETRY_SHIFT’ undeclared (first use in this function)
reg |= RTL818X_CW_CONF_PERPACKET_RETRY_SHIFT;
^
drivers/net/wireless/rtl818x/rtl8187/dev.c:788:9: note: each undeclared
identifier is reported only once for each function it appears in
drivers/net/wireless/rtl818x/rtl8187/dev.c: In function ‘rtl8187_start’:
drivers/net/wireless/rtl818x/rtl8187/dev.c:946:11: error:
‘RTL818X_TX_AGC_CTL_PERPACKET_GAIN_SHIFT’ undeclared (first use in this
function)
reg &= ~RTL818X_TX_AGC_CTL_PERPACKET_GAIN_SHIFT;
^
drivers/net/wireless/rtl818x/rtl8187/dev.c:947:11: error:
‘RTL818X_TX_AGC_CTL_PERPACKET_ANTSEL_SHIFT’ undeclared (first use in this function)
reg &= ~RTL818X_TX_AGC_CTL_PERPACKET_ANTSEL_SHIFT;
^
drivers/net/wireless/rtl818x/rtl8187/dev.c:952:7: error:
‘RTL818X_TX_CONF_HW_SEQNUM’ undeclared (first use in this function)
RTL818X_TX_CONF_HW_SEQNUM |
^
drivers/net/wireless/rtl818x/rtl8187/dev.c:989:10: error:
‘RTL818X_CW_CONF_PERPACKET_CW_SHIFT’ undeclared (first use in this function)
reg &= ~RTL818X_CW_CONF_PERPACKET_CW_SHIFT;
^
drivers/net/wireless/rtl818x/rtl8187/dev.c:990:9: error:
‘RTL818X_CW_CONF_PERPACKET_RETRY_SHIFT’ undeclared (first use in this function)
reg |= RTL818X_CW_CONF_PERPACKET_RETRY_SHIFT;
The warning is fixed by
Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187/dev.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187/dev.c
+++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187/dev.c
@@ -593,7 +593,7 @@ static void rtl8187_set_anaparam(struct
rtl818x_iowrite32(priv, &priv->map->ANAPARAM, anaparam);
rtl818x_iowrite32(priv, &priv->map->ANAPARAM2, anaparam2);
if (priv->is_rtl8187b)
- rtl818x_iowrite8(priv, &priv->map->ANAPARAM3, anaparam3);
+ rtl818x_iowrite16(priv, &priv->map->ANAPARAM3, anaparam3);
reg &= ~RTL818X_CONFIG3_ANAPARAM_WRITE;
rtl818x_iowrite8(priv, &priv->map->CONFIG3, reg);
rtl818x_iowrite8(priv, &priv->map->EEPROM_CMD,
For testing purposes, I have turned on the build for rtl8187.
Larry
next prev parent reply other threads:[~2014-02-04 17:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52ee2ee736e00_2c3211fc86c5851f@209.249.196.67.mail>
[not found] ` <20140202160512.GA4946@redhat.com>
2014-02-02 18:07 ` rtl8821ae Stefan Lippers-Hollmann
2014-02-02 19:36 ` rtl8821ae Malcolm Priestley
2014-02-03 17:05 ` rtl8821ae Larry Finger
2014-02-03 20:02 ` rtl8821ae Dan Carpenter
2014-02-03 20:12 ` rtl8821ae Dan Carpenter
2014-02-03 20:18 ` rtl8821ae Linus Torvalds
[not found] ` <CAN8YU5PJWqnaBN_oaZ-yZjV-s9oCkKPa4ebk-kNbhPSgpd3_wQ@mail.gmail.com>
2014-02-04 9:28 ` rtl8821ae Dan Carpenter
2014-02-04 14:41 ` rtl8821ae Andrea Merello
2014-02-04 15:42 ` rtl8821ae Larry Finger
2014-02-04 17:57 ` Larry Finger [this message]
2014-02-04 19:57 ` rtl8821ae Andrea Merello
2014-02-04 23:05 ` rtl8821ae Larry Finger
2014-02-05 10:52 ` rtl8821ae Andrea Merello
2014-02-05 12:34 ` rtl8821ae Dan Carpenter
2014-02-05 14:49 ` rtl8821ae Andrea Merello
2014-02-04 18:00 ` rtl8821ae Linus Torvalds
2014-02-03 20:19 ` rtl8821ae Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F12A10.3020600@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=andrea.merello@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=davej@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.L-H@gmx.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).