From: Felix Fietkau <nbd@openwrt.org>
To: Cedric VONCKEN <cedric.voncken@acksys.fr>,
linux-wireless@vger.kernel.org
Subject: Re: ATH9K software retry
Date: Thu, 06 Feb 2014 15:42:09 +0100 [thread overview]
Message-ID: <52F39F41.2010300@openwrt.org> (raw)
In-Reply-To: <773DB8A82AB6A046AE0195C68612A3190173371A@sbs2003.acksys.local>
On 2014-02-06 14:06, Cedric VONCKEN wrote:
> In xmit.c the function ath_tx_complete_aggr test if the fi->retries <
> ATH_MAX_SW_RETRIES.
>
> If this condition is true, ATH9K handle software retry.
>
> Minstrel set in the frame one or more rates, for each rate minstrel set
> a retries count. I think is sufficient.
>
> Why ATH9K need to manage the software retries?
The retries configured for minstrel_ht are used for hardware retries of
single frames and full A-MPDU transmissions. Software retries are used
for individual subframes that are sent as part of A-MPDUs.
This is required, because failed subframes are frequent with higher MCS
rates and A-MPDU.
> With the test we have a minimal of 30 retries (ATH_MAX_SW_RETRIES is set
> to 30).
>
> I plan to remove the software retry int ATH9K, before I would like to
> know if theses retries is necessary.
Removing software retry functionality is a very bad idea.
- Felix
next prev parent reply other threads:[~2014-02-06 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 13:06 ATH9K software retry Cedric VONCKEN
2014-02-06 14:42 ` Felix Fietkau [this message]
2014-02-06 16:38 ` voncken
2014-02-06 16:56 ` Felix Fietkau
2014-02-06 17:59 ` voncken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F39F41.2010300@openwrt.org \
--to=nbd@openwrt.org \
--cc=cedric.voncken@acksys.fr \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).