From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-oa0-f48.google.com ([209.85.219.48]:55406 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751705AbaBGPqc (ORCPT ); Fri, 7 Feb 2014 10:46:32 -0500 Message-ID: <52F4FFD5.5070808@lwfinger.net> (sfid-20140207_164706_353229_A718F24F) Date: Fri, 07 Feb 2014 09:46:29 -0600 From: Larry Finger MIME-Version: 1.0 To: Kalle Valo , Johannes Berg CC: Calvin Owens , "David S. Miller" , "John W. Linville" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ieee80211: Print human-readable disassoc/deauth reason codes References: <1391651088-31785-1-git-send-email-jcalvinowens@gmail.com> <1391675824.12789.3.camel@jlt4.sipsolutions.net> <87r47fkrsj.fsf@purkki.adurom.net> In-Reply-To: <87r47fkrsj.fsf@purkki.adurom.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 02/07/2014 06:53 AM, Kalle Valo wrote: > Johannes Berg writes: > >> On Wed, 2014-02-05 at 19:44 -0600, Calvin Owens wrote: >>> Create a function to return a descriptive string for each reason code, >>> and print that instead of the numeric value in the kernel log. These >>> codes are easily found on popular search engines, but one is generally >>> not able to access the internet when dealing with wireless connectivity >>> issues. >> >> I believe both iw and wpa_supplicant already have the reason code >> printout, and if you're diagnosing connectivity issues then you're >> probably using those anyway (e.g. iw event -t), so I don't really see >> much point in adding this to the kernel? > > FWIW I find this useful. When I have connection problems I rarely look > at wpasupplicant, mostly I'm so lazy that I just check from the kernel > log what's happening. Just my 0.02 EUR. I would also find it useful. I assist with wireless problems on the openSUSE Forum, and there we are lucky if we get dmesg output. When we do and it contains a deauthentication reason, I always need to bring up a web page to interpret the output. With this change, one step could be skipped.