From: Arend van Spriel <arend@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Emmanuel Grumbach <egrumbach@gmail.com>,
<linux-wireless@vger.kernel.org>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH 2/8] iwlwifi: mvm: disable scheduled scan
Date: Mon, 10 Feb 2014 15:30:21 +0100 [thread overview]
Message-ID: <52F8E27D.6020601@broadcom.com> (raw)
In-Reply-To: <1392019923.4128.0.camel@jlt4.sipsolutions.net>
On 02/10/2014 09:12 AM, Johannes Berg wrote:
> On Sat, 2014-02-08 at 10:42 +0100, Arend van Spriel wrote:
>> On 02/03/14 21:39, Emmanuel Grumbach wrote:
>>> From: Johannes Berg<johannes.berg@intel.com>
>>>
>>> The iwlwifi scheduled scan implementation doesn't adhere to the
>>> userspace API correctly - the API assumes that any new incoming
>>> 'incompatible' request (like scan or remain-on-channel for this
>>> driver) will just cancel the scheduled scan. Instead our driver
>>> relies on userspace cancelling it, thus breaking existing wpa_s
>>> versions.
>>
>> I think iwlwifi is not alone in this. At least I have to put a new task
>> on my todo list ;-)
>
> :)
> You may decide to not care - newer supplicant seems to always cancel
> scheduled scan first (although that should never have been required,
> Broadcom's proprietary Android driver also behaves to require that.)
When implementing scheduled scan, I found our firmware can handle a
regular scan regardless whether a scheduled scan is active or not.
> However, you may find that you don't just need to support the latest
> upstream wpa_supplicant, so ...
Yeah, seems to happen more often than not. Also when people start using
backports they are advised to upgrade user-space apps as well, but tend
to stick to what the distro has, so ...
> johannes
Arend
next prev parent reply other threads:[~2014-02-10 14:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 20:32 pull request: iwlwifi 2014-02-03 Emmanuel Grumbach
2014-02-03 20:39 ` [PATCH 1/8] iwlwifi: mvm: make local pointer non-static Emmanuel Grumbach
2014-02-03 20:39 ` [PATCH 2/8] iwlwifi: mvm: disable scheduled scan Emmanuel Grumbach
2014-02-08 9:42 ` Arend van Spriel
2014-02-10 8:12 ` Johannes Berg
2014-02-10 14:30 ` Arend van Spriel [this message]
2014-02-10 14:37 ` Johannes Berg
2014-02-03 20:39 ` [PATCH 3/8] iwlwifi: mvm: print the version of the firmware when it asserts Emmanuel Grumbach
2014-02-03 20:39 ` [PATCH 4/8] iwlwifi: add more 7265 HW IDs Emmanuel Grumbach
2014-02-03 20:39 ` [PATCH 5/8] iwlwifi: mvm: notify match found without filtering Emmanuel Grumbach
2014-02-03 20:39 ` [PATCH 6/8] iwlwifi: mvm: don't leak a station when we drain Emmanuel Grumbach
2014-02-03 20:39 ` [PATCH 7/8] iwlwifi: mvm: BT Coex - disable BT when TXing probe request in scan Emmanuel Grumbach
2014-02-03 20:39 ` [PATCH 8/8] iwlwifi: mvm: don't allow A band if SKU forbids it Emmanuel Grumbach
2014-02-04 20:15 ` pull request: iwlwifi 2014-02-03 John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F8E27D.6020601@broadcom.com \
--to=arend@broadcom.com \
--cc=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).