From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <sujith@msujith.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 2/2] ath9k: implement p2p client powersave support
Date: Wed, 12 Feb 2014 16:52:00 +0100 [thread overview]
Message-ID: <52FB98A0.7080306@openwrt.org> (raw)
In-Reply-To: <21243.38599.474190.76004@gargle.gargle.HOWL>
On 2014-02-12 16:44, Sujith Manoharan wrote:
> Felix Fietkau wrote:
>> It only allocates a very small struct. Doing this in the interface
>> add/remove callback means I'd have to handle interface change as well. I
>> figured keeping it simple is better than micro-optimizing a single small
>> memory allocation.
>
> I think doing this in the interface callbacks would be cleaner since
> this won't be required for normal ap/sta operations at all.
Actually, I just remembered, that I'm also using this timer in my
unfinished multi-channel concurrency patches (for channel switching), so
I don't want to move it to the interface callbacks only to move it back
again later.
- Felix
prev parent reply other threads:[~2014-02-12 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 10:18 [PATCH 1/2] ath9k: support only one P2P interface Felix Fietkau
2014-02-11 10:18 ` [PATCH 2/2] ath9k: implement p2p client powersave support Felix Fietkau
2014-02-12 15:12 ` Sujith Manoharan
2014-02-12 15:32 ` Felix Fietkau
2014-02-12 15:44 ` Sujith Manoharan
2014-02-12 15:52 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FB98A0.7080306@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).