[3.14 FIX][PATCH] bcma: gpio: register all 32 GPIOs

[3.14 FIX][PATCH] bcma: gpio: register all 32 GPIOs

[Rafał Miłecki]

Broadcom boards have 32 GPIOs (not 16) and these higher ones are
actually used on some devices (for buttons, reset of WiFi devices).

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
Similar patch may be needed for ssb, however I didn't meet any ssb SoC
with GPIOs 16-31 connected to anything.
This is so trivial I hope it can go as a fix for 3.14. It allows support
for some devices that use these higher GPIOs.
---
 drivers/bcma/driver_gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bcma/driver_gpio.c b/drivers/bcma/driver_gpio.c
index 25f9887..2f0ceac 100644
--- a/drivers/bcma/driver_gpio.c
+++ b/drivers/bcma/driver_gpio.c
@@ -218,7 +218,7 @@ int bcma_gpio_init(struct bcma_drv_cc *cc)
 #if IS_BUILTIN(CONFIG_BCMA_HOST_SOC)
 	chip->to_irq		= bcma_gpio_to_irq;
 #endif
-	chip->ngpio		= 16;
+	chip->ngpio		= 32;
 	/* There is just one SoC in one device and its GPIO addresses should be
 	 * deterministic to address them more easily. The other buses could get
 	 * a random base number. */
-- 
1.8.4.5

Re: [3.14 FIX][PATCH] bcma: gpio: register all 32 GPIOs

[Rafał Miłecki]

2014-02-13 18:06 GMT+01:00 Rafał Miłecki <zajec5@gmail.com>:
> Broadcom boards have 32 GPIOs (not 16) and these higher ones are
> actually used on some devices (for buttons, reset of WiFi devices).

I forgot about one important thing. This patch is based on top of
changes from 3.14-rc1.

John: do you plan to pull David's net.git tree into your wireless.git?

Re: [3.14 FIX][PATCH] bcma: gpio: register all 32 GPIOs

[John W. Linville]

On Thu, Feb 13, 2014 at 09:04:24PM +0100, Rafał Miłecki wrote:
> 2014-02-13 18:06 GMT+01:00 Rafał Miłecki <zajec5@gmail.com>:
> > Broadcom boards have 32 GPIOs (not 16) and these higher ones are
> > actually used on some devices (for buttons, reset of WiFi devices).
> 
> I forgot about one important thing. This patch is based on top of
> changes from 3.14-rc1.
> 
> John: do you plan to pull David's net.git tree into your wireless.git?

No.

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [3.14 FIX][PATCH] bcma: gpio: register all 32 GPIOs

[Hauke Mehrtens]

On 02/13/2014 06:06 PM, Rafał Miłecki wrote:
> Broadcom boards have 32 GPIOs (not 16) and these higher ones are
> actually used on some devices (for buttons, reset of WiFi devices).
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> Similar patch may be needed for ssb, however I didn't meet any ssb SoC
> with GPIOs 16-31 connected to anything.
> This is so trivial I hope it can go as a fix for 3.14. It allows support
> for some devices that use these higher GPIOs.
> ---
>  drivers/bcma/driver_gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Are you sure all the bcma SoC have 32 GPIO lines or is there no problem
when they do not? For at least some ssb based SoCs I know that they only
have 16 GPIO lines.

Hauke

Re: [3.14 FIX][PATCH] bcma: gpio: register all 32 GPIOs

[Rafał Miłecki]

2014-02-14 0:34 GMT+01:00 Hauke Mehrtens <hauke@hauke-m.de>:
> On 02/13/2014 06:06 PM, Rafał Miłecki wrote:
>> Broadcom boards have 32 GPIOs (not 16) and these higher ones are
>> actually used on some devices (for buttons, reset of WiFi devices).
>>
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>> ---
>> Similar patch may be needed for ssb, however I didn't meet any ssb SoC
>> with GPIOs 16-31 connected to anything.
>> This is so trivial I hope it can go as a fix for 3.14. It allows support
>> for some devices that use these higher GPIOs.
>> ---
>>  drivers/bcma/driver_gpio.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> Are you sure all the bcma SoC have 32 GPIO lines or is there no problem
> when they do not? For at least some ssb based SoCs I know that they only
> have 16 GPIO lines.

Damn, I'm afraid you may be right. I didn't think about that.

I was able to find references to GPIOs 16-31 on BCM5357 based boards only.

-- 
Rafał

Re: [3.14 FIX][PATCH] bcma: gpio: register all 32 GPIOs

[John W. Linville]

On Fri, Feb 14, 2014 at 01:01:00PM +0100, Rafał Miłecki wrote:
> 2014-02-14 0:34 GMT+01:00 Hauke Mehrtens <hauke@hauke-m.de>:
> > On 02/13/2014 06:06 PM, Rafał Miłecki wrote:
> >> Broadcom boards have 32 GPIOs (not 16) and these higher ones are
> >> actually used on some devices (for buttons, reset of WiFi devices).
> >>
> >> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> >> ---
> >> Similar patch may be needed for ssb, however I didn't meet any ssb SoC
> >> with GPIOs 16-31 connected to anything.
> >> This is so trivial I hope it can go as a fix for 3.14. It allows support
> >> for some devices that use these higher GPIOs.
> >> ---
> >>  drivers/bcma/driver_gpio.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> > Are you sure all the bcma SoC have 32 GPIO lines or is there no problem
> > when they do not? For at least some ssb based SoCs I know that they only
> > have 16 GPIO lines.
> 
> Damn, I'm afraid you may be right. I didn't think about that.
> 
> I was able to find references to GPIOs 16-31 on BCM5357 based boards only.

Sounds like I need to revert that patch.

Please never, _ever_, post a patch (no matter how trivial) for the
stable tree unless you are absolutely sure about it in the first place.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [3.14 FIX][PATCH] bcma: gpio: register all 32 GPIOs

[Rafał Miłecki]

2014-02-14 15:27 GMT+01:00 John W. Linville <linville@tuxdriver.com>:
> On Fri, Feb 14, 2014 at 01:01:00PM +0100, Rafał Miłecki wrote:
>> 2014-02-14 0:34 GMT+01:00 Hauke Mehrtens <hauke@hauke-m.de>:
>> > On 02/13/2014 06:06 PM, Rafał Miłecki wrote:
>> >> Broadcom boards have 32 GPIOs (not 16) and these higher ones are
>> >> actually used on some devices (for buttons, reset of WiFi devices).
>> >>
>> >> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>> >> ---
>> >> Similar patch may be needed for ssb, however I didn't meet any ssb SoC
>> >> with GPIOs 16-31 connected to anything.
>> >> This is so trivial I hope it can go as a fix for 3.14. It allows support
>> >> for some devices that use these higher GPIOs.
>> >> ---
>> >>  drivers/bcma/driver_gpio.c | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> > Are you sure all the bcma SoC have 32 GPIO lines or is there no problem
>> > when they do not? For at least some ssb based SoCs I know that they only
>> > have 16 GPIO lines.
>>
>> Damn, I'm afraid you may be right. I didn't think about that.
>>
>> I was able to find references to GPIOs 16-31 on BCM5357 based boards only.
>
> Sounds like I need to revert that patch.
>
> Please never, _ever_, post a patch (no matter how trivial) for the
> stable tree unless you are absolutely sure about it in the first place.

I'm sorry. I got blinded by the triviality :(

-- 
Rafał