From: Antonio Quartulli <antonio@meshcoding.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Justin van Wijngaarden <justinvanwijngaarden@gmail.com>
Cc: linville@tuxdriver.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Drivers: net: wireless: mac80211_hwim fixed coding style issues
Date: Sat, 15 Feb 2014 20:53:17 +0100 [thread overview]
Message-ID: <52FFC5AD.4080003@meshcoding.com> (raw)
In-Reply-To: <1392488030.4298.5.camel@jlt4.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On 15/02/14 19:13, Johannes Berg wrote:
> On Sat, 2014-02-15 at 12:55 +0100, Justin van Wijngaarden wrote:
>
>> @@ -1,19 +1,17 @@
>> -/*
>> - * mac80211_hwsim - software simulator of 802.11 radio(s) for mac80211
>> +/* mac80211_hwsim - software simulator of 802.11 radio(s) for mac80211
>
> I don't see any point in this - lots of code exists both ways, that's
> really just fluff. The difference isn't even interesting enough to be
> worth fixing up.
This is how David S. Miller wants multiline comments to start in files
within the networking subsystem......but I know you don't like it ;)
(I just wanted to justify Justin).
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-02-15 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 11:55 [PATCH] Drivers: net: wireless: mac80211_hwim fixed coding style issues Justin van Wijngaarden
2014-02-15 18:13 ` Johannes Berg
2014-02-15 19:53 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FFC5AD.4080003@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=johannes@sipsolutions.net \
--cc=justinvanwijngaarden@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).