* lockdep warning (needs annotation) @ 2014-02-17 23:57 Ben Greear 2014-02-18 7:16 ` Michal Kazior 0 siblings, 1 reply; 5+ messages in thread From: Ben Greear @ 2014-02-17 23:57 UTC (permalink / raw) To: ath10k, linux-wireless@vger.kernel.org I started seeing this today after synch-ing with upstream ath10k tree. Firmware is modified, and there are some patches to ath10k in my tree, but probably nothing that affects this. INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 1 PID: 213 Comm: kworker/u8:2 Tainted: G C 3.14.0-rc2-wl-ath+ #11 Hardware name: To be filled by O.E.M. To be filled by O.E.M./HURONRIVER, BIOS 4.6.5 05/02/2012 Workqueue: phy0 ieee80211_iface_work [mac80211] 0000000000000000 ffff88020fd777e8 ffffffff815d0007 0000000000000006 0000000000000000 ffff88020fd77868 ffffffff810fb81e ffff88020fd77818 ffffffff00000000 ffff880200000001 0000000000000002 0000000000000000 Call Trace: [<ffffffff815d0007>] dump_stack+0x4e/0x71 [<ffffffff810fb81e>] register_lock_class+0x11a/0x2f0 [<ffffffff810fcc2b>] __lock_acquire+0xe0/0xe48 [<ffffffff815d7592>] ? _raw_spin_unlock_irq+0x28/0x42 [<ffffffff810fc966>] ? mark_lock+0x2d/0x212 [<ffffffff810fc966>] ? mark_lock+0x2d/0x212 [<ffffffff810fdd9f>] lock_acquire+0x82/0x9d [<ffffffff810d6abe>] ? queue_delayed_work_on+0x85/0x85 [<ffffffff810d6b07>] flush_work+0x49/0x289 [<ffffffff810d6abe>] ? queue_delayed_work_on+0x85/0x85 [<ffffffff810fc966>] ? mark_lock+0x2d/0x212 [<ffffffff810fe0a8>] ? mark_held_locks+0x71/0x99 [<ffffffff810d8758>] ? __cancel_work_timer+0x89/0xbf [<ffffffff810d8769>] __cancel_work_timer+0x9a/0xbf [<ffffffff810d87a9>] cancel_work_sync+0xb/0xd [<ffffffffa0515b4b>] ath10k_sta_state+0x4b/0x48e [ath10k_core] [<ffffffffa030dbaa>] drv_sta_state+0x87/0x17b [mac80211] [<ffffffffa030f632>] __sta_info_destroy_part2+0xca/0x2a0 [mac80211] [<ffffffffa030f9b5>] __sta_info_destroy+0x25/0x2f [mac80211] [<ffffffffa030fb19>] sta_info_destroy_addr+0x39/0x59 [mac80211] [<ffffffffa0331eb0>] ieee80211_destroy_auth_data+0x31/0xbc [mac80211] [<ffffffffa0335382>] ieee80211_sta_work+0x16b/0xbe6 [mac80211] [<ffffffff810fe0a8>] ? mark_held_locks+0x71/0x99 [<ffffffff815d75ec>] ? _raw_spin_unlock_irqrestore+0x40/0x5e [<ffffffff810fe215>] ? trace_hardirqs_on_caller+0x145/0x1a1 [<ffffffff815d75f4>] ? _raw_spin_unlock_irqrestore+0x48/0x5e [<ffffffffa0319c4a>] ieee80211_iface_work+0x2a3/0x2c6 [mac80211] [<ffffffff810d7eb9>] process_one_work+0x1d7/0x2fc [<ffffffff810d7e4f>] ? process_one_work+0x16d/0x2fc [<ffffffff810d518c>] ? spin_lock_irq+0x9/0xb [<ffffffff810d83b1>] worker_thread+0x12e/0x1fb [<ffffffff810d8283>] ? rescuer_thread+0x27b/0x27b [<ffffffff810dd70d>] kthread+0xc4/0xcc [<ffffffff810dd649>] ? __kthread_parkme+0x5c/0x5c [<ffffffff815dc40c>] ret_from_fork+0x7c/0xb0 [<ffffffff810dd649>] ? __kthread_parkme+0x5c/0x5c Thanks, Ben -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: lockdep warning (needs annotation) 2014-02-17 23:57 lockdep warning (needs annotation) Ben Greear @ 2014-02-18 7:16 ` Michal Kazior 2014-02-19 7:33 ` [PATCH] ath10k: fix sta_rc_update for non-ap iftype Michal Kazior 0 siblings, 1 reply; 5+ messages in thread From: Michal Kazior @ 2014-02-18 7:16 UTC (permalink / raw) To: Ben Greear; +Cc: ath10k, linux-wireless@vger.kernel.org On 18 February 2014 00:57, Ben Greear <greearb@candelatech.com> wrote: > I started seeing this today after synch-ing with upstream > ath10k tree. > > Firmware is modified, and there are some patches to ath10k in my > tree, but probably nothing that affects this. > > > INFO: trying to register non-static key. > the code is fine but needs lockdep annotation. > turning off the locking correctness validator. > CPU: 1 PID: 213 Comm: kworker/u8:2 Tainted: G C 3.14.0-rc2-wl-ath+ #11 > Hardware name: To be filled by O.E.M. To be filled by O.E.M./HURONRIVER, BIOS 4.6.5 05/02/2012 > Workqueue: phy0 ieee80211_iface_work [mac80211] > 0000000000000000 ffff88020fd777e8 ffffffff815d0007 0000000000000006 > 0000000000000000 ffff88020fd77868 ffffffff810fb81e ffff88020fd77818 > ffffffff00000000 ffff880200000001 0000000000000002 0000000000000000 > Call Trace: > [<ffffffff815d0007>] dump_stack+0x4e/0x71 > [<ffffffff810fb81e>] register_lock_class+0x11a/0x2f0 > [<ffffffff810fcc2b>] __lock_acquire+0xe0/0xe48 > [<ffffffff815d7592>] ? _raw_spin_unlock_irq+0x28/0x42 > [<ffffffff810fc966>] ? mark_lock+0x2d/0x212 > [<ffffffff810fc966>] ? mark_lock+0x2d/0x212 > [<ffffffff810fdd9f>] lock_acquire+0x82/0x9d > [<ffffffff810d6abe>] ? queue_delayed_work_on+0x85/0x85 > [<ffffffff810d6b07>] flush_work+0x49/0x289 > [<ffffffff810d6abe>] ? queue_delayed_work_on+0x85/0x85 > [<ffffffff810fc966>] ? mark_lock+0x2d/0x212 > [<ffffffff810fe0a8>] ? mark_held_locks+0x71/0x99 > [<ffffffff810d8758>] ? __cancel_work_timer+0x89/0xbf > [<ffffffff810d8769>] __cancel_work_timer+0x9a/0xbf > [<ffffffff810d87a9>] cancel_work_sync+0xb/0xd > [<ffffffffa0515b4b>] ath10k_sta_state+0x4b/0x48e [ath10k_core] > [<ffffffffa030dbaa>] drv_sta_state+0x87/0x17b [mac80211] > [<ffffffffa030f632>] __sta_info_destroy_part2+0xca/0x2a0 [mac80211] > [<ffffffffa030f9b5>] __sta_info_destroy+0x25/0x2f [mac80211] > [<ffffffffa030fb19>] sta_info_destroy_addr+0x39/0x59 [mac80211] > [<ffffffffa0331eb0>] ieee80211_destroy_auth_data+0x31/0xbc [mac80211] > [<ffffffffa0335382>] ieee80211_sta_work+0x16b/0xbe6 [mac80211] > [<ffffffff810fe0a8>] ? mark_held_locks+0x71/0x99 > [<ffffffff815d75ec>] ? _raw_spin_unlock_irqrestore+0x40/0x5e > [<ffffffff810fe215>] ? trace_hardirqs_on_caller+0x145/0x1a1 > [<ffffffff815d75f4>] ? _raw_spin_unlock_irqrestore+0x48/0x5e > [<ffffffffa0319c4a>] ieee80211_iface_work+0x2a3/0x2c6 [mac80211] > [<ffffffff810d7eb9>] process_one_work+0x1d7/0x2fc > [<ffffffff810d7e4f>] ? process_one_work+0x16d/0x2fc > [<ffffffff810d518c>] ? spin_lock_irq+0x9/0xb > [<ffffffff810d83b1>] worker_thread+0x12e/0x1fb > [<ffffffff810d8283>] ? rescuer_thread+0x27b/0x27b > [<ffffffff810dd70d>] kthread+0xc4/0xcc > [<ffffffff810dd649>] ? __kthread_parkme+0x5c/0x5c > [<ffffffff815dc40c>] ret_from_fork+0x7c/0xb0 > [<ffffffff810dd649>] ? __kthread_parkme+0x5c/0x5c Oops! I think this is my fault.. I'll look into this. Thanks! Michał ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ath10k: fix sta_rc_update for non-ap iftype 2014-02-18 7:16 ` Michal Kazior @ 2014-02-19 7:33 ` Michal Kazior 2014-02-19 19:47 ` Ben Greear 2014-02-26 16:40 ` Kalle Valo 0 siblings, 2 replies; 5+ messages in thread From: Michal Kazior @ 2014-02-19 7:33 UTC (permalink / raw) To: ath10k; +Cc: greearb, linux-wireless, Michal Kazior The arsta structure wasn't initialized for non-ap interfaces. This should fix related warnings/crashes. Reported-By: Ben Greear <greearb@candelatech.com> Signed-off-by: Michal Kazior <michal.kazior@tieto.com> --- Ben, does this fix the lockdep splat for you? drivers/net/wireless/ath/ath10k/mac.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 94a70a9..9cb3eae 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -3207,6 +3207,13 @@ static int ath10k_sta_state(struct ieee80211_hw *hw, int max_num_peers; int ret = 0; + if (old_state == IEEE80211_STA_NOTEXIST && + new_state == IEEE80211_STA_NONE) { + memset(arsta, 0, sizeof(*arsta)); + arsta->arvif = arvif; + INIT_WORK(&arsta->update_wk, ath10k_sta_rc_update_wk); + } + /* cancel must be done outside the mutex to avoid deadlock */ if ((old_state == IEEE80211_STA_NONE && new_state == IEEE80211_STA_NOTEXIST)) @@ -3236,10 +3243,6 @@ static int ath10k_sta_state(struct ieee80211_hw *hw, "mac vdev %d peer create %pM (new sta) num_peers %d\n", arvif->vdev_id, sta->addr, ar->num_peers); - memset(arsta, 0, sizeof(*arsta)); - arsta->arvif = arvif; - INIT_WORK(&arsta->update_wk, ath10k_sta_rc_update_wk); - ret = ath10k_peer_create(ar, arvif->vdev_id, sta->addr); if (ret) ath10k_warn("Failed to add peer %pM for vdev %d when adding a new sta: %i\n", -- 1.8.5.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ath10k: fix sta_rc_update for non-ap iftype 2014-02-19 7:33 ` [PATCH] ath10k: fix sta_rc_update for non-ap iftype Michal Kazior @ 2014-02-19 19:47 ` Ben Greear 2014-02-26 16:40 ` Kalle Valo 1 sibling, 0 replies; 5+ messages in thread From: Ben Greear @ 2014-02-19 19:47 UTC (permalink / raw) To: Michal Kazior; +Cc: ath10k, linux-wireless On 02/18/2014 11:33 PM, Michal Kazior wrote: > The arsta structure wasn't initialized for > non-ap interfaces. This should fix related > warnings/crashes. > > Reported-By: Ben Greear <greearb@candelatech.com> > Signed-off-by: Michal Kazior <michal.kazior@tieto.com> > --- > Ben, does this fix the lockdep splat for you? This does appear to fix it. Thanks, Ben -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ath10k: fix sta_rc_update for non-ap iftype 2014-02-19 7:33 ` [PATCH] ath10k: fix sta_rc_update for non-ap iftype Michal Kazior 2014-02-19 19:47 ` Ben Greear @ 2014-02-26 16:40 ` Kalle Valo 1 sibling, 0 replies; 5+ messages in thread From: Kalle Valo @ 2014-02-26 16:40 UTC (permalink / raw) To: Michal Kazior; +Cc: ath10k, greearb, linux-wireless Michal Kazior <michal.kazior@tieto.com> writes: > The arsta structure wasn't initialized for > non-ap interfaces. This should fix related > warnings/crashes. > > Reported-By: Ben Greear <greearb@candelatech.com> > Signed-off-by: Michal Kazior <michal.kazior@tieto.com> Thanks, applied. -- Kalle Valo ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-26 16:40 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-02-17 23:57 lockdep warning (needs annotation) Ben Greear 2014-02-18 7:16 ` Michal Kazior 2014-02-19 7:33 ` [PATCH] ath10k: fix sta_rc_update for non-ap iftype Michal Kazior 2014-02-19 19:47 ` Ben Greear 2014-02-26 16:40 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).