From: Arend van Spriel <arend@broadcom.com>
To: Joe Perches <joe@perches.com>, Denys Vlasenko <dvlasenk@redhat.com>
Cc: Franky Lin <frankyl@broadcom.com>,
Hante Meuleman <meuleman@broadcom.com>,
<linux-kernel@vger.kernel.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c: deinline brcmf_sdio_chip_cr4_enterdl, save 440 bytes
Date: Tue, 18 Feb 2014 18:24:55 +0100 [thread overview]
Message-ID: <53039767.1060907@broadcom.com> (raw)
In-Reply-To: <1392732925.22752.26.camel@joe-AO722>
On 02/18/2014 03:15 PM, Joe Perches wrote:
> On Tue, 2014-02-18 at 15:05 +0100, Denys Vlasenko wrote:
>> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
>
> Hi Denys
>
> Perhaps these patch subjects would be better without
> the file path, but shortened to something like:
>
> brcmfmac: sdio_chip: deinline function to reduce object size
Indeed, only the driver name prefix is nice to have so
brcmfmac: deinline <func_name> to reduce object size
Given that you are updating sdio_chip.c makes me conclude that you did
not make these changes in the wireless-next repository. Can you please
resubmit them for wireless-next/master.
Regards,
Arend
next prev parent reply other threads:[~2014-02-18 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 14:05 [PATCH] drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c: deinline brcmf_sdio_chip_cr4_enterdl, save 440 bytes Denys Vlasenko
2014-02-18 14:15 ` Joe Perches
2014-02-18 17:24 ` Arend van Spriel [this message]
2014-02-18 17:26 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53039767.1060907@broadcom.com \
--to=arend@broadcom.com \
--cc=dvlasenk@redhat.com \
--cc=frankyl@broadcom.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).