[PATCH] drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c: deinline brcmf_sdio_chip_cr4_enterdl, save 440 bytes

[PATCH] drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c: deinline brcmf_sdio_chip_cr4_enterdl, save 440 bytes

[Denys Vlasenko]

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
---
 drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c b/drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c
index 82bf3c5..b810ab5 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c
@@ -900,7 +900,7 @@ static bool brcmf_sdio_chip_cm3_exitdl(struct brcmf_sdio_dev *sdiodev,
 	return true;
 }
 
-static inline void
+static void
 brcmf_sdio_chip_cr4_enterdl(struct brcmf_sdio_dev *sdiodev,
 			    struct brcmf_chip *ci)
 {
-- 
1.8.1.4

Re: [PATCH] drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c: deinline brcmf_sdio_chip_cr4_enterdl, save 440 bytes

[Joe Perches]

On Tue, 2014-02-18 at 15:05 +0100, Denys Vlasenko wrote:
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>

Hi Denys

Perhaps these patch subjects would be better without
the file path, but shortened to something like:

brcmfmac: sdio_chip: deinline function to reduce object size

Re: [PATCH] drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c: deinline brcmf_sdio_chip_cr4_enterdl, save 440 bytes

[Arend van Spriel]

On 02/18/2014 03:15 PM, Joe Perches wrote:
> On Tue, 2014-02-18 at 15:05 +0100, Denys Vlasenko wrote:
>> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> 
> Hi Denys
> 
> Perhaps these patch subjects would be better without
> the file path, but shortened to something like:
> 
> brcmfmac: sdio_chip: deinline function to reduce object size

Indeed, only the driver name prefix is nice to have so

brcmfmac: deinline <func_name> to reduce object size

Given that you are updating sdio_chip.c makes me conclude that you did
not make these changes in the wireless-next repository. Can you please
resubmit them for wireless-next/master.

Regards,
Arend

Re: [PATCH] drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c: deinline brcmf_sdio_chip_cr4_enterdl, save 440 bytes

[Arend van Spriel]

On 02/18/2014 06:24 PM, Arend van Spriel wrote:
> On 02/18/2014 03:15 PM, Joe Perches wrote:
>> On Tue, 2014-02-18 at 15:05 +0100, Denys Vlasenko wrote:
>>> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
>>
>> Hi Denys
>>
>> Perhaps these patch subjects would be better without
>> the file path, but shortened to something like:
>>
>> brcmfmac: sdio_chip: deinline function to reduce object size
> 
> Indeed, only the driver name prefix is nice to have so
> 
> brcmfmac: deinline <func_name> to reduce object size
> 
> Given that you are updating sdio_chip.c makes me conclude that you did
> not make these changes in the wireless-next repository. Can you please
> resubmit them for wireless-next/master.

O, and the patch should be sent to John Linville as he is the wireless
maintainer.

> Regards,
> Arend
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>