linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ath9k: Enable U-APSD AP mode support
@ 2014-02-18 18:41 Jouni Malinen
  2014-02-18 19:05 ` Johannes Berg
  0 siblings, 1 reply; 4+ messages in thread
From: Jouni Malinen @ 2014-02-18 18:41 UTC (permalink / raw)
  To: John W. Linville; +Cc: linux-wireless

mac80211 handles the actual operations, so ath9k can just indicate
support for this. Based on initial tests, this combination seems to
work fine.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/init.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 07a0315..4856a17 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -949,6 +949,7 @@ static void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
 	hw->wiphy->flags |= WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL;
 	hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_5_10_MHZ;
 	hw->wiphy->flags |= WIPHY_FLAG_HAS_CHANNEL_SWITCH;
+	hw->wiphy->flags |= WIPHY_FLAG_AP_UAPSD;
 
 	hw->queues = 4;
 	hw->max_rates = 4;
-- 
1.7.9.5


-- 
Jouni Malinen                                            PGP id EFC895FA

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ath9k: Enable U-APSD AP mode support
  2014-02-18 18:41 [PATCH] ath9k: Enable U-APSD AP mode support Jouni Malinen
@ 2014-02-18 19:05 ` Johannes Berg
  2014-02-18 22:18   ` Felix Fietkau
  0 siblings, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2014-02-18 19:05 UTC (permalink / raw)
  To: Jouni Malinen; +Cc: John W. Linville, linux-wireless

On Tue, 2014-02-18 at 20:41 +0200, Jouni Malinen wrote:
> mac80211 handles the actual operations, so ath9k can just indicate
> support for this. Based on initial tests, this combination seems to
> work fine.

I believe this is not true with aggregation sessions.

johannes


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ath9k: Enable U-APSD AP mode support
  2014-02-18 19:05 ` Johannes Berg
@ 2014-02-18 22:18   ` Felix Fietkau
  2014-02-19  9:48     ` Johannes Berg
  0 siblings, 1 reply; 4+ messages in thread
From: Felix Fietkau @ 2014-02-18 22:18 UTC (permalink / raw)
  To: Johannes Berg, Jouni Malinen; +Cc: John W. Linville, linux-wireless

On 2014-02-18 20:05, Johannes Berg wrote:
> On Tue, 2014-02-18 at 20:41 +0200, Jouni Malinen wrote:
>> mac80211 handles the actual operations, so ath9k can just indicate
>> support for this. Based on initial tests, this combination seems to
>> work fine.
> 
> I believe this is not true with aggregation sessions.
Why not? Block Ack Window handling is handled by
.release_buffered_frames just fine (and tested with PS-Poll).

- Felix


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ath9k: Enable U-APSD AP mode support
  2014-02-18 22:18   ` Felix Fietkau
@ 2014-02-19  9:48     ` Johannes Berg
  0 siblings, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2014-02-19  9:48 UTC (permalink / raw)
  To: Felix Fietkau; +Cc: Jouni Malinen, John W. Linville, linux-wireless

On Tue, 2014-02-18 at 23:18 +0100, Felix Fietkau wrote:
> On 2014-02-18 20:05, Johannes Berg wrote:
> > On Tue, 2014-02-18 at 20:41 +0200, Jouni Malinen wrote:
> >> mac80211 handles the actual operations, so ath9k can just indicate
> >> support for this. Based on initial tests, this combination seems to
> >> work fine.
> > 
> > I believe this is not true with aggregation sessions.
> Why not? Block Ack Window handling is handled by
> .release_buffered_frames just fine (and tested with PS-Poll).

Yeah, n/m, I missed that you implemented that.

johannes


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-02-19  9:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-18 18:41 [PATCH] ath9k: Enable U-APSD AP mode support Jouni Malinen
2014-02-18 19:05 ` Johannes Berg
2014-02-18 22:18   ` Felix Fietkau
2014-02-19  9:48     ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).