From: Dave Kilroy <kilroyd@googlemail.com>
To: "Zhao, Gang" <gamerh2o@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/7] orinoco: replace function ieee80211_{dsss_chan_to_freq, freq_to_dsss_chan}
Date: Wed, 19 Feb 2014 08:33:34 +0000 [thread overview]
Message-ID: <53046C5E.5070208@gmail.com> (raw)
In-Reply-To: <be3f8f8f679b4665e3306869a35f830a94e727df.1392728354.git.gamerh2o@gmail.com>
On 18/02/2014 13:36, Zhao, Gang wrote:
> Replace ieee80211_{dsss_chan_to_freq, freq_to_dsss_chan} with more
> generic ieee80211_{channel_to_frequency, frequency_to_channel}.
>
> File <net/cfg80211.h> has already been included. It's safe to use
> IEEE80211_BAND_2GHZ here.
>
> This change is a preparation for the removal of function
> ieee80211_{dsss_chan_to_freq, freq_to_dsss_chan}.
>
> Signed-off-by: Zhao, Gang <gamerh2o@gmail.com>
> ---
> drivers/net/wireless/orinoco/cfg.c | 4 ++--
> drivers/net/wireless/orinoco/hw.c | 2 +-
> drivers/net/wireless/orinoco/scan.c | 5 +++--
> drivers/net/wireless/orinoco/wext.c | 2 +-
> 4 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/orinoco/cfg.c b/drivers/net/wireless/orinoco/cfg.c
> index d01edd2..c5ef3ab 100644
> --- a/drivers/net/wireless/orinoco/cfg.c
> +++ b/drivers/net/wireless/orinoco/cfg.c
> @@ -59,7 +59,7 @@ int orinoco_wiphy_register(struct wiphy *wiphy)
> for (i = 0; i < NUM_CHANNELS; i++) {
> if (priv->channel_mask & (1 << i)) {
> priv->channels[i].center_freq =
> - ieee80211_dsss_chan_to_freq(i + 1);
> + ieee80211_channel_to_frequency(i + 1, IEEE80211_BAND_2GHZ);
> channels++;
> }
Can you tweak that indentation so that it doesn't unindent here. If it
has to be on one line I'd prefer to exceed 80 chars than back indent.
Thanks,
Dave.
next prev parent reply other threads:[~2014-02-19 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 13:35 [PATCH 0/7] api clean: ieee80211_{dsss_chan_to_freq, freq_to_dsss_chan} Zhao, Gang
2014-02-18 13:35 ` [PATCH 1/7] airo: replace function " Zhao, Gang
2014-02-18 13:35 ` [PATCH 2/7] atmel: " Zhao, Gang
2014-02-18 13:35 ` [PATCH 3/7] wl3501_cs: " Zhao, Gang
2014-02-18 13:36 ` [PATCH 4/7] rndis_wlan: " Zhao, Gang
2014-02-18 13:36 ` [PATCH 5/7] zd1201: " Zhao, Gang
2014-02-18 13:36 ` [PATCH 6/7] orinoco: " Zhao, Gang
2014-02-19 8:33 ` Dave Kilroy [this message]
2014-02-19 8:58 ` [PATCH 6/7 v2] " Zhao, Gang
2014-02-18 13:36 ` [PATCH 7/7] ieee80211: remove " Zhao, Gang
2014-02-19 0:59 ` Zhao, Gang
2014-02-28 18:58 ` John W. Linville
2014-02-19 11:00 ` [PATCH 0/7] api clean: " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53046C5E.5070208@gmail.com \
--to=kilroyd@googlemail.com \
--cc=gamerh2o@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).