From: Malcolm Priestley <tvboxspy@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] staging: vt6656: Remove typedef enum _CONTEXT_TYPE
Date: Wed, 19 Feb 2014 22:29:31 +0000 [thread overview]
Message-ID: <5305304B.5050004@gmail.com> (raw)
In-Reply-To: <1392848134.24844.16.camel@joe-AO722>
On 19/02/14 22:15, Joe Perches wrote:
> On Wed, 2014-02-19 at 21:56 +0000, Malcolm Priestley wrote:
>> Replace with enum
>> assign as u8 type.
> []
>> diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h
> []
>> @@ -180,7 +180,7 @@ struct vnt_usb_send_context {
>> struct sk_buff *pPacket;
>> struct urb *pUrb;
>> unsigned int uBufLen;
>> - CONTEXT_TYPE Type;
>> + u8 type;
>
> This doesn't really save any space in the struct.
> You might move it immediately before or after bBoolInUse.
>
>> struct ethhdr sEthHeader;
>> void *Next;
>> bool bBoolInUse;
>
>
No, but there are dead members in the structure that need removing.
sEthHeader and Next are dead
next prev parent reply other threads:[~2014-02-19 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 21:56 [PATCH 4/4] staging: vt6656: Remove typedef enum _CONTEXT_TYPE Malcolm Priestley
2014-02-19 22:15 ` Joe Perches
2014-02-19 22:29 ` Malcolm Priestley [this message]
2014-02-19 22:31 ` Joe Perches
2014-02-19 22:59 ` Malcolm Priestley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5305304B.5050004@gmail.com \
--to=tvboxspy@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).