pull request: iwlwifi 2014-02-23

pull request: iwlwifi 2014-02-23

[Emmanuel Grumbach]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

Hi John,

One single patch for this pull request intended for 3.14.
This should fix an issue raised in iwldvm when we have lots of association failures.
There is a bugzilla for this bug - it hasn't been validated by the user, but I hope it will do the trick.

I hope I fixed my line wrapping issue this time. Let me know if you are still unhappy with the current format.

Thanks!
The following changes since commit 205e2210daa975d92ace485a65a31ccc4077fe1a:

  iwlwifi: disable TX AMPDU by default for iwldvm (2014-02-13 15:24:35 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git master

for you to fetch changes up to ec6f678c74dbdb06a6a775bbb00f1d26c17c404b:

  iwlwifi: dvm: clear IWL_STA_UCODE_INPROGRESS when assoc fails (2014-02-20 19:16:27 +0200)

----------------------------------------------------------------
Emmanuel Grumbach (1):
      iwlwifi: dvm: clear IWL_STA_UCODE_INPROGRESS when assoc fails

 drivers/net/wireless/iwlwifi/dvm/sta.c |    1 +
 1 file changed, 1 insertion(+)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[PATCH] iwlwifi: dvm: clear IWL_STA_UCODE_INPROGRESS when assoc fails

[Emmanuel Grumbach]

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

We set IWL_STA_UCODE_INPROGRESS flag when we add a station
and clear it when we send the LQ command for it. But the LQ
command is sent only when the association succeeds.
If the association doesn't succeed, we would leave this flag
set and that wouldn't indicate the station entry as vacant.

This probably fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1065663

Cc: <stable@vger.kernel.org>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
 drivers/net/wireless/iwlwifi/dvm/sta.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/iwlwifi/dvm/sta.c b/drivers/net/wireless/iwlwifi/dvm/sta.c
index c0d070c..9cdd91c 100644
--- a/drivers/net/wireless/iwlwifi/dvm/sta.c
+++ b/drivers/net/wireless/iwlwifi/dvm/sta.c
@@ -590,6 +590,7 @@ void iwl_deactivate_station(struct iwl_priv *priv, const u8 sta_id,
 			sizeof(priv->tid_data[sta_id][tid]));
 
 	priv->stations[sta_id].used &= ~IWL_STA_DRIVER_ACTIVE;
+	priv->stations[sta_id].used &= ~IWL_STA_UCODE_INPROGRESS;
 
 	priv->num_stations--;
 
-- 
1.7.9.5

Re: pull request: iwlwifi 2014-02-23

[John W. Linville]

On Sun, Feb 23, 2014 at 09:19:36PM +0200, Emmanuel Grumbach wrote:
> Hi John,
> 
> One single patch for this pull request intended for 3.14.
> This should fix an issue raised in iwldvm when we have lots of association failures.
> There is a bugzilla for this bug - it hasn't been validated by the user, but I hope it will do the trick.
> 
> I hope I fixed my line wrapping issue this time. Let me know if you are still unhappy with the current format.
> 
> Thanks!
> The following changes since commit 205e2210daa975d92ace485a65a31ccc4077fe1a:
> 
>   iwlwifi: disable TX AMPDU by default for iwldvm (2014-02-13 15:24:35 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git master
> 
> for you to fetch changes up to ec6f678c74dbdb06a6a775bbb00f1d26c17c404b:
> 
>   iwlwifi: dvm: clear IWL_STA_UCODE_INPROGRESS when assoc fails (2014-02-20 19:16:27 +0200)

Pulling now...

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.