From: Malcolm Priestley <tvboxspy@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-wireless@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH 09/10] staging: vt6656: Remove pointer cast to urb->context.
Date: Tue, 25 Feb 2014 21:07:30 +0000 [thread overview]
Message-ID: <530D0612.9080004@gmail.com> (raw)
In-Reply-To: <1393361512-13805-9-git-send-email-tvboxspy@gmail.com>
added Joe's cc
On 25/02/14 20:51, Malcolm Priestley wrote:
> Remove unnecessary cast to void * urb->context
>
> Reported-by: Joe Perches <joe@perches.com>
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> ---
> drivers/staging/vt6656/usbpipe.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
> index 1477def..54c68a5 100644
> --- a/drivers/staging/vt6656/usbpipe.c
> +++ b/drivers/staging/vt6656/usbpipe.c
> @@ -347,7 +347,7 @@ int PIPEnsInterruptRead(struct vnt_private *priv)
>
> static void s_nsInterruptUsbIoCompleteRead(struct urb *urb)
> {
> - struct vnt_private *priv = (struct vnt_private *)urb->context;
> + struct vnt_private *priv = urb->context;
> int status;
>
> DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO
> @@ -465,7 +465,7 @@ int PIPEnsBulkInUsbRead(struct vnt_private *priv, struct vnt_rcb *rcb)
>
> static void s_nsBulkInUsbIoCompleteRead(struct urb *urb)
> {
> - struct vnt_rcb *rcb = (struct vnt_rcb *)urb->context;
> + struct vnt_rcb *rcb = urb->context;
> struct vnt_private *priv = rcb->pDevice;
> int re_alloc_skb = false;
>
> @@ -592,8 +592,7 @@ int PIPEnsSendBulkOut(struct vnt_private *priv,
>
> static void s_nsBulkOutIoCompleteWrite(struct urb *urb)
> {
> - struct vnt_usb_send_context *context =
> - (struct vnt_usb_send_context *)urb->context;
> + struct vnt_usb_send_context *context = urb->context;
> struct vnt_private *priv = context->pDevice;
> u8 context_type = context->type;
> unsigned long buf_len = context->uBufLen;
>
next prev parent reply other threads:[~2014-02-25 21:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 20:51 [PATCH 01/10] staging: vt6656: PIPEnsSendBulkOut reverse if statement Malcolm Priestley
2014-02-25 20:51 ` [PATCH 02/10] staging: vt6656: usb_fill_bulk_urb get rid of void* cast Malcolm Priestley
2014-02-25 20:51 ` [PATCH 03/10] staging: vt6656: clean up PIPEnsSendBulkOut Malcolm Priestley
2014-02-25 20:51 ` [PATCH 04/10] staging: vt6656: s_nsBulkInUsbIoCompleteRead get rid of status Malcolm Priestley
2014-02-25 20:51 ` [PATCH 05/10] staging: vt6656: s_nsBulkInUsbIoCompleteRead Remove bytesRead/bIndicateReceive Malcolm Priestley
2014-02-25 20:51 ` [PATCH 06/10] staging: vt6656: s_nsBulkInUsbIoCompleteRead Replace error handling Malcolm Priestley
2014-02-25 20:51 ` [PATCH 07/10] staging: vt6656: clean up s_nsBulkInUsbIoCompleteRead Malcolm Priestley
2014-02-25 20:51 ` [PATCH 08/10] staging: vt6656: Cleanup PIPEnsBulkInUsbRead Malcolm Priestley
2014-02-25 20:51 ` [PATCH 09/10] staging: vt6656: Remove pointer cast to urb->context Malcolm Priestley
2014-02-25 21:07 ` Malcolm Priestley [this message]
2014-02-25 20:51 ` [PATCH 10/10] staging: vt6656: struct vnt_usb_send_context struct size optimization Malcolm Priestley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530D0612.9080004@gmail.com \
--to=tvboxspy@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).