From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:41328 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202AbaBZMS3 (ORCPT ); Wed, 26 Feb 2014 07:18:29 -0500 Message-ID: <530DDB91.3070807@broadcom.com> (sfid-20140226_131837_827088_E7E1C2D3) Date: Wed, 26 Feb 2014 13:18:25 +0100 From: Arend van Spriel MIME-Version: 1.0 To: Johannes Berg CC: "John W. Linville" , linux-wireless , David Miller , Subject: Re: [PATCH 01/14] brcmfmac: add delay before unregistering the network device References: <1393356639-19169-1-git-send-email-arend@broadcom.com> <1393356639-19169-2-git-send-email-arend@broadcom.com> (sfid-20140225_203048_842452_A39499B6) <1393358376.4170.22.camel@jlt4.sipsolutions.net> <530DAECD.8010405@broadcom.com> <1393406278.4133.4.camel@jlt4.sipsolutions.net> <530DB3BA.20106@broadcom.com> <1393407473.4133.5.camel@jlt4.sipsolutions.net> <530DC56E.9040202@broadcom.com> <1393413044.4133.6.camel@jlt4.sipsolutions.net> <530DD131.50205@broadcom.com> <1393415288.4133.7.camel@jlt4.sipsolutions.net> In-Reply-To: <1393415288.4133.7.camel@jlt4.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 02/26/2014 12:48 PM, Johannes Berg wrote: > On Wed, 2014-02-26 at 12:34 +0100, Arend van Spriel wrote: > >>> I'm not sure this isn't still possible? I don't know when DELLINK is >>> sent. >> >> Given the behaviour I would say before the netdev notifier, which may be >> considered wrong. It depends whether the notifier was intended for the >> kind of thing that cfg80211 is doing, ie. send a netlink event to >> user-space? > > Well, I checked: > > call_netdevice_notifiers(NETDEV_UNREGISTER, dev); > > if (!dev->rtnl_link_ops || > dev->rtnl_link_state == RTNL_LINK_INITIALIZED) > rtmsg_ifinfo(RTM_DELLINK, dev, ~0U, GFP_KERNEL); > > so ... :) Feeling sad :-( but thanks for checking. Clearly need to look into this some more. John, can you please drop this one. Gr. AvS