From: Arend van Spriel <arend@broadcom.com>
To: David Herrmann <dh.herrmann@gmail.com>, <netdev@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Kay Sievers <kay.sievers@vrfy.org>, Tom Gundersen <teg@jklm.no>,
Johannes berg <johannes@sipsolutions.net>,
<linux-kernel@vger.kernel.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/4] brcmfmac: set NET_NAME_USER for P2P ifs
Date: Thu, 27 Feb 2014 18:30:22 +0100 [thread overview]
Message-ID: <530F762E.6030301@broadcom.com> (raw)
In-Reply-To: <1393512434-1325-5-git-send-email-dh.herrmann@gmail.com>
On 02/27/2014 03:47 PM, David Herrmann wrote:
> Netdevs created via nl80211 (currently only P2P ifs) have names provided
> by user-space. Therefore, set the naming-policy to NET_NAME_USER so it is
> correctly shown in sysfs.
>
- Cc: Arend van Spriel <arend@broadcom.com>
+ Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/p2p.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
> index fc4f98b..6af4d26 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
> @@ -2310,6 +2310,7 @@ struct wireless_dev *brcmf_p2p_add_vif(struct wiphy *wiphy, const char *name,
> goto fail;
> }
>
> + ifp->ndev->name_assign_type = NET_NAME_USER;
> strncpy(ifp->ndev->name, name, sizeof(ifp->ndev->name) - 1);
> err = brcmf_net_attach(ifp, true);
> if (err) {
>
next prev parent reply other threads:[~2014-02-27 17:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 14:47 [PATCH 0/4] Provide netdev naming-policy via sysfs David Herrmann
2014-02-27 14:47 ` [PATCH 1/4] net: add name_assign_type netdev attribute David Herrmann
2014-02-27 14:47 ` [PATCH 2/4] mac80211: set NET_NAME_USER for user-space created ifs David Herrmann
2014-02-27 14:53 ` Johannes Berg
2014-02-27 14:56 ` David Herrmann
2014-02-27 16:18 ` Johannes Berg
2014-02-27 17:14 ` David Herrmann
2014-02-27 14:47 ` [PATCH 3/4] ath6kl: set NET_NAME_USER for P2P ifs David Herrmann
2014-02-27 15:27 ` Kalle Valo
2014-02-27 16:13 ` Kalle Valo
2014-02-27 14:47 ` [PATCH 4/4] brcmfmac: " David Herrmann
2014-02-27 17:30 ` Arend van Spriel [this message]
2014-02-27 15:47 ` [PATCH 0/4] Provide netdev naming-policy via sysfs Tom Gundersen
2014-03-01 14:19 ` Tom Gundersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530F762E.6030301@broadcom.com \
--to=arend@broadcom.com \
--cc=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=teg@jklm.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).